Godot Engine - Project Manager 4.0.alpha4 - can't resolve https://godotengine.org/asset-library/api/

[mo-moxi-gd]

Godot version

v4.0.alpha4.official(f470979)

System information

Debian 11 (Bulleye)

Issue description

Project manager can't resolve https://godotengine.org/asset-library/api/

Steps to reproduce

Load Godot alpha 4, then select asset library projects

Minimal reproduction project

No response

[Sauermann]

I am unable to reproduce this issue on Debian 11 with v4.0.alpha4.official [f470979].
It works for me.

[Calinou]

@mo-moxi-gd Are you behind an HTTP proxy or a dual-stack IPv4/IPv6 connection?

Support for HTTP proxies was added in master, but it currently needs to be configured manually in the Editor Settings (after creating a project).

[Sniperchang]

I have this issue. According to the conversation in this issue, I seem to have a broken dual-stack, where I can ping godotengine.org via IPv4 but not IPv6. But I don't have this issue with V3.4.3

[RibalGZ]

I have this issue. According to the conversation in this issue, I seem to have a broken dual-stack, where I can ping godotengine.org via IPv4 but not IPv6. But I don't have this issue with V3.4.3

Same problem here using the master branch.

[taisph]

Godot outputs the message below to the console:

ERROR: getaddrinfo failed! Cannot resolve hostname.
   at: _resolve_hostname (drivers/unix/ip_unix.cpp:98)

godot/drivers/unix/ip_unix.cpp

Lines 96 to 100 in f470979

	int s = getaddrinfo(p_hostname.utf8().get_data(), nullptr, &hints, &result);
	if (s != 0) {
	ERR_PRINT("getaddrinfo failed! Cannot resolve hostname.");
	return;
	}

It seems to be caused by the proxy handling code. It expects the proxy host to be empty or the port to be -1, but when it gets the proxy config from the editor settings, if they are not set, proxy host is U"null" (.is_empty() is then false) and port is 0, which makes godot try and fail to resolve the proxy host.

godot/core/io/http_client_tcp.cpp

Lines 761 to 779 in f470979

	void HTTPClientTCP::set_http_proxy(const String &p_host, int p_port) {
	if (p_host.is_empty() || p_port == -1) {
	http_proxy_host = "";
	http_proxy_port = -1;
	} else {
	http_proxy_host = p_host;
	http_proxy_port = p_port;
	}
	}
	void HTTPClientTCP::set_https_proxy(const String &p_host, int p_port) {
	if (p_host.is_empty() || p_port == -1) {
	https_proxy_host = "";
	https_proxy_port = -1;
	} else {
	https_proxy_host = p_host;
	https_proxy_port = p_port;
	}
	}

Adding network/http_proxy/port = -1 to the "~/.config/godot/editor_settings-4.tres" file is enough to make Godot ignore the proxy and the asset library no longer fails to lookup the host. Maybe setting the editor defaults is a good approach.