-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy support for the editor #55747
Conversation
* Adds proxy support for `HTTPRequest`. * Adds `network/http_proxy/{host,port}` editor settings. * Labeled as "HTTP Proxy" and it will be used for both HTTP and HTTPS requests. This is the same convention as seen in Android Studio's proxy settings. * Makes Asset Library and Export Template Manager use proxy according to the editor settings.
I can do a separate 3.x PR for these two proxy PRs after this one is merged. Adding the |
On desktop platforms, I believe the |
Yeah, these environment variables are definitely the way to go. Meanwhile, on Windows and macOS, desktop applications tend to honor the system proxy settings which have to be queried via API, I think. p.s. Personally, I use the lower cased |
This is a straighforward change after the proxy PR. Looks good, and thanks for working on this! |
Thanks! |
Authenticated proxy doesnt work. |
Please open a new issue for this, while detailing your OS and proxy configuration (which authentication method does it use?).
|
Follow-up of #47257.
HTTPRequest
.network/http_proxy/{host,port}
editor settings.The proxy has to be set manually in Editor Settings. It would be a separate PR trying to figure out default proxy from environment variables on different platforms 😜
Fixes #6100.