Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose loading TGA images in Image. #38920

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Expose loading TGA images in Image. #38920

merged 1 commit into from
Jun 30, 2020

Conversation

paulherman
Copy link
Contributor

@paulherman paulherman mentioned this pull request May 21, 2020
Closed
@Calinou Calinou added this to the 4.0 milestone May 21, 2020
@Calinou Calinou added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label May 21, 2020
@paulherman paulherman marked this pull request as ready for review May 21, 2020 14:33
@paulherman paulherman mentioned this pull request May 22, 2020
Closed
@paulherman
Copy link
Contributor Author

Is there some process I am missing to get the PR reviewed and merged? It's been 1m so I assume I missed a step :)

@Calinou
Copy link
Member

Calinou commented Jun 30, 2020 •
edited
Loading

@paulherman I don't think you missed a step; it's just that the pull request backlog is very large with almost 800 open PRs. That said, providing a minimal project for testing this PR may help it get merged faster.

For the record, I don't merge PRs on the main repository (Akien usually does it instead).

@akien-mga akien-mga merged commit f3c5f12 into godotengine:master Jun 30, 2020
@akien-mga
Copy link
Member

Thanks!

@paulherman
Copy link
Contributor Author

Thanks both! Perhaps a graph explaining the backload / burndown rate might help provide transparency (if Github has it). FTR, that's why I was asking about unit tests while referencing this PR - it's much easier than to provide a project.

@akien-mga
Copy link
Member

Cherry-picked for 3.2.3.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jul 3, 2020
@Calinou
Copy link
Member

Calinou commented Jul 3, 2020

@paulherman The Pulse graph should have this information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paulherman @Calinou @akien-mga