-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Fix for iOS touch recognition #39624
[4.0] Fix for iOS touch recognition #39624
Conversation
74e9578
to
4669d1f
Compare
4669d1f
to
3b4ac0c
Compare
3b4ac0c
to
067b0e3
Compare
Sorry, something happened while rebasing and GitHub added a review request on it's own, and it seems I can't remove request =( |
341d067
to
e794c5f
Compare
I cherry-picked this commit onto 3.2.2-stable and unfortunately it introduces problems with dragging. It is easily reproducible with an HSlider. It always starts dragging only after a few hundred milliseconds after I begin to drag the slider. This applies not only to Sliders but to all touch input events, which makes drawing apps impossible. Reverting this commit fixes the regression. |
Using The point of delaying touches, by the same amount used by |
@timoschwarzer can you check latest changes? I've checked them on iPad, plus on iPhone 6 and XS and it seems like a scrolling issue went away as well as saving the fix. |
@naithar I will, thank you for the fast response! :) |
@naithar the new patch works just fine, I didn't find any regressions. Thank you very much! :) |
a4d656a
to
bec048e
Compare
I've rebased and made some additional changes, but they don't seem to be present in PR for some reason: naithar@52aef81 |
ae7f6c5
to
52aef81
Compare
Hmm, for me it shows that this PR is on 52aef81... |
Yeah, seems like it got fixed by itself :) |
This gesture recognizer will prevent GodotView from processing unwanted gestures. Emulates UIScrollView behavior. Fires delayed touches on significant movement.
52aef81
to
e6d7e01
Compare
Thanks! |
Fixes #39509
Custom
UIGestureRecognizers
gives more control over touch recognition and should be working stable enough so that new iOS release does not render fix useless or causes more bugs.Using
UIScrollView
as base for Godot'sGLView
may result in getting unexpected and undocumented changes in Private API after release of new iOS version.Usage of
UIScrollViewDelayedTouchesBeganGestureRecognizer
gives no result for simpleUIView
and it is also part of Private API, which could lead to application rejection.Tested on both
master
and3.2
branch.