-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit TCP/UDP socket binding, local port retrieval. #47398
Merged
akien-mga
merged 2 commits into
godotengine:master
from
Faless:feature/network-local-port-salvaged
Apr 27, 2021
Merged
Explicit TCP/UDP socket binding, local port retrieval. #47398
akien-mga
merged 2 commits into
godotengine:master
from
Faless:feature/network-local-port-salvaged
Apr 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faless
changed the title
[WIP] Explicit TCP/UDP socket binding, local port retrieval.
[WIP] [salvage] Explicit TCP/UDP socket binding, local port retrieval.
Mar 26, 2021
Faless
force-pushed
the
feature/network-local-port-salvaged
branch
from
April 12, 2021 15:18
2cc2a47
to
2589711
Compare
Should be good to go when CI passes. |
Faless
changed the title
[WIP] [salvage] Explicit TCP/UDP socket binding, local port retrieval.
[salvage] Explicit TCP/UDP socket binding, local port retrieval.
Apr 12, 2021
Calinou
previously requested changes
Apr 12, 2021
akien-mga
changed the title
[salvage] Explicit TCP/UDP socket binding, local port retrieval.
Explicit TCP/UDP socket binding, local port retrieval.
Apr 12, 2021
Faless
force-pushed
the
feature/network-local-port-salvaged
branch
2 times, most recently
from
April 12, 2021 19:04
43ee337
to
bbd153a
Compare
Faless
force-pushed
the
feature/network-local-port-salvaged
branch
from
April 12, 2021 19:05
bbd153a
to
4d5c8e0
Compare
Thanks for the review! Addressed the issues. |
akien-mga
approved these changes
Apr 27, 2021
Thanks! |
This was referenced Apr 27, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on salvaging #43174 .
In this PR:
bind
of sockets used byPacketPeerUDP
andStreamPeerTCP
.get_local_port
to TCP/UDP classes to retrieve local port.PacketPeerUDP.listen
toPacketPeerUDP.bind
to make it consistent with TCP, and separate the concept of client/server (abstracted byUDPServer
) and socket binding.