Use an enum to represent screen orientation in the Project Settings #48939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
commented
May 21, 2021
Comment on lines
+503
to
+504
| case DisplayServer::SCREEN_LANDSCAPE: | ||
| orientations += "<string>UIInterfaceOrientationLandscapeLeft</string>\n"; |
There was a problem hiding this comment.
Can anyone confirm that SCREEN_LANDSCAPE has the left side of the device pointing upwards? I'm just guessing here.
There was a problem hiding this comment.
https://developer.apple.com/documentation/uikit/uiinterfaceorientation/landscapeleft seems about right. But I can't test it at the moment.
Calinou
commented
May 21, 2021
Comment on lines
+509
to
+510
| case DisplayServer::SCREEN_REVERSE_LANDSCAPE: | ||
| orientations += "<string>UIInterfaceOrientationLandscapeRight</string>\n"; |
There was a problem hiding this comment.
Same as above – it should be the opposite.
Calinou
force-pushed
the
screen-orientation-use-enum
branch
from
90067b8
to
10c052d
Compare
m4gr3d
requested changes
May 24, 2021
Calinou
force-pushed
the
screen-orientation-use-enum
branch
from
10c052d
to
c5d9134
Compare
m4gr3d
approved these changes
May 24, 2021
akien-mga
reviewed
May 24, 2021
- Tweak the setting property hint to be more informative.
- Make the setting a "basic" setting so it appears when Advanced Settings
is disabled.
- Remove redundant orientation setting in the iOS export preset.
The project setting is now used (like on Android).
Projects upgrading from a previous version will have to set the
screen orientation again in the Project Settings if it wasn't set
to the default value ("landscape").
Calinou
force-pushed
the
screen-orientation-use-enum
branch
from
c5d9134
to
660952a
Compare
akien-mga
approved these changes
May 24, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterversion of #48943 (not backwards compatible).Projects upgrading from a previous version will have to set the screen orientation again in the Project Settings if it wasn't set to the default value ("landscape").
This closes #45422.