New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Blend Import #54886
Add Blend Import #54886
Conversation
026aa46
to
5ff3bdc
Compare
0244b01
to
96e31e0
Compare
Just chatted with @fire and I think it would make more sense to move the blender path into EditorSettings, since I do not want to input my blender executable path in every single project on windows, and also would not want to check it into version control by mistake. I am also apprehensive about the settings for the blender python scripts being per-project. There was an idea of some use-case where a user customizes the blender export to hack in additional features, but my opinion is that level of customization would be best left to custom GDScript addons. Hardcoding the python strings would be easiest. I'd also be ok with having the scripts as an editor setting. |
7f73fe1
to
5156331
Compare
QA tested reports
Checked means there is a bugfix in for the issues. |
a4751c4
to
7fb7e07
Compare
I pushed updates (for now as a separate commit) to https://github.com/akien-mga/godot/tree/blend-io to move the class in It's still not perfect though, whether the import can be done is validated on editor init, so enabling Blend import requires first setting the Blender path, and then enabling the option. Otherwise before my changes you would enter import hell since it would fail repeatedly until you kill Godot, and now after my changes it will just not register the importer. But that's part of what @reduz is going to improve in a follow-up. Otherwise, I tested the version check and it doesn't seem to work. Picking a Blender 2.93 binary, I did not see I renamed the |
I saw your message. I'll update the V-Sekai fork promptly. |
Can leave the version check and the validation on editor initialization to future commits. Thanks! |
Seems like I broke the editor with a last minute change, will fix. |
@fire I updated my branch if you can push to this PR again: https://github.com/akien-mga/godot/tree/blend-io |
Lets you drag or place .blend files in the project folder and it will import the files. Checks for Blender 3.0's gltf2 `export_keep_originals` option. Add basepath support to GLTFDocument append_from_file. Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
Thanks! |
When I start the editor, I only see "Blender Path" in EditorSettings, not "Import Enabled", and just setting "Blender Path" does not seem to enable blend imports. Edit: NVM, it is a project setting, and you have to check "advanced settings" to see it |
This PR is a continuation to godotengine#54886 * Changed Blender path editor setting from binary to installation. * Add a class to query whether the format is supported. * This class allows to create proper editors to configure support. **NOTE**: This PR only provides autodetection on Linux. Code needs to be added for Windows and MacOS to autodetect the Blender installation.
This PR is a continuation to godotengine#54886 * Changed Blender path editor setting from binary to installation. * Add a class to query whether the format is supported. * This class allows to create proper editors to configure support. **NOTE**: This PR only provides autodetection on Linux. Code needs to be added for Windows and MacOS to autodetect the Blender installation.
This PR is a continuation to godotengine#54886 * Changed Blender path editor setting from binary to installation. * Add a class to query whether the format is supported. * This class allows to create proper editors to configure support. **NOTE**: This PR only provides autodetection on Linux. Code needs to be added for Windows and MacOS to autodetect the Blender installation. Co-authored-by: bruvzg <7645683+bruvzg@users.noreply.github.com> Co-authored-by: Pedro J. Estébanez <pedrojrulez@gmail.com>
This PR is a continuation to godotengine#54886 * Changed Blender path editor setting from binary to installation. * Add a class to query whether the format is supported. * This class allows to create proper editors to configure support. **NOTE**: This PR only provides autodetection on Linux. Code needs to be added for Windows and MacOS to autodetect the Blender installation. Co-authored-by: bruvzg <7645683+bruvzg@users.noreply.github.com> Co-authored-by: Pedro J. Estébanez <pedrojrulez@gmail.com>
Where do I find the docs on this? Does this support geometry nodes? |
@Zireael07 it just exports to |
Fixes godotengine/godot-proposals#3529
Discussed with the Godot Discord community and with Reduz.