Bind EditorFileSystem::reimport_files and improve docs #61004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
May 13, 2022
akien-mga
reviewed
May 13, 2022
lyuma
force-pushed
the
reimport_files
branch
2 times, most recently
from
b254b19
to
f48898b
Compare
akien-mga
reviewed
May 17, 2022
akien-mga
approved these changes
May 17, 2022
reimport_files offers a way for scripts to modify imported resources directly. For example, images, sounds or glTF documents which are written by an external program. It is much faster than `scan`, and can allow scripts to synchronously proceed after import finishes.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reimport_files offers a way for scripts to modify imported resources directly.
For example, images, sounds or glTF documents which are written by an external program.
It is much faster than
scan, and can allow scripts to synchronously proceed after import finishes. This also gives a nice way to modify resources without hitting the reentrancy bug #46893, since I can set a boolean to true before the call toreimport_filesand set it to false afterwards, or simply drive the import process in a single function without using asynchronous methods.I'm using this in Unidot-Importer to import .jpg/.png images, .gltf documents and sound files such .wav/.mp3/.ogg and it seems to be very fast and pleasant to use, both firing a signal and returning when complete.
This function was probably intended to be public, given that its name does not begin with an underscore.