Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jumbled error output when using Windows spawn fix #64306

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

RandomShaper
Copy link
Member

In situations where the spawn fix is needed, compiler errors are reported like this because of Popen using stream mode by default:

=====
b"modules\\gltf\\structures\\gltf_skeleton.cpp:36:1: error: unknown type name 'intt'; did you mean 'int'?\r\nintt a;\r\n^~~~\r\nint\r\n1 error generated.\r\n"
=====

In contrast, with this PR, they look like this:

=====
modules\gltf\structures\gltf_skeleton.cpp:36:1: error: unknown type name 'intt'; did you mean 'int'?
intt a;
^~~~
int
1 error generated.

=====

@RandomShaper RandomShaper added topic:buildsystem cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Aug 12, 2022
@RandomShaper RandomShaper added this to the 4.0 milestone Aug 12, 2022
@RandomShaper RandomShaper requested a review from a team as a code owner August 12, 2022 08:43
@clayjohn clayjohn merged commit 22bb15c into godotengine:master Aug 12, 2022
@clayjohn
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the win_spawn_text branch August 12, 2022 16:43
@akien-mga
Copy link
Member

Cherry-picked for 3.6.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Aug 24, 2022
@akien-mga
Copy link
Member

Cherry-picked for 3.5.1.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 29, 2022
m4gr3d added a commit to m4gr3d/godot that referenced this pull request Aug 31, 2022
The issue is caused by godotengine#64306 which makes use of a 3.7 feature while the current recommended python version is 3.5 for 3.x and 3.6 for master.
akien-mga pushed a commit that referenced this pull request Sep 1, 2022
The issue is caused by #64306 which makes use of a 3.7 feature while the current recommended python version is 3.5 for 3.x and 3.6 for master.

(cherry picked from commit 667f4ed)
akien-mga pushed a commit that referenced this pull request Sep 1, 2022
The issue is caused by #64306 which makes use of a 3.7 feature while the current recommended python version is 3.5 for 3.x and 3.6 for master.

(cherry picked from commit 667f4ed)
Relintai pushed a commit to Relintai/pandemonium_engine that referenced this pull request Sep 16, 2022
The issue is caused by godotengine/godot#64306 which makes use of a 3.7 feature while the current recommended python version is 3.5 for 3.x and 3.6 for master.

(cherry picked from commit 667f4ed742e0010adb678dff45e004310c4886d4)
Riordan-DC pushed a commit to Riordan-DC/godot that referenced this pull request Jan 24, 2023
The issue is caused by godotengine#64306 which makes use of a 3.7 feature while the current recommended python version is 3.5 for 3.x and 3.6 for master.

(cherry picked from commit 667f4ed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants