-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jumbled error output when using Windows spawn fix #64306
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
added
topic:buildsystem
cherrypick:3.x
Considered for cherry-picking into a future 3.x release
cherrypick:3.5
Considered for cherry-picking into a future 3.5.x release
labels
Aug 12, 2022
akien-mga
approved these changes
Aug 12, 2022
Thanks! |
Cherry-picked for 3.6. |
akien-mga
removed
the
cherrypick:3.x
Considered for cherry-picking into a future 3.x release
label
Aug 24, 2022
Cherry-picked for 3.5.1. |
akien-mga
removed
the
cherrypick:3.5
Considered for cherry-picking into a future 3.5.x release
label
Aug 29, 2022
m4gr3d
added a commit
to m4gr3d/godot
that referenced
this pull request
Aug 31, 2022
The issue is caused by godotengine#64306 which makes use of a 3.7 feature while the current recommended python version is 3.5 for 3.x and 3.6 for master.
Relintai
pushed a commit
to Relintai/pandemonium_engine
that referenced
this pull request
Sep 16, 2022
The issue is caused by godotengine/godot#64306 which makes use of a 3.7 feature while the current recommended python version is 3.5 for 3.x and 3.6 for master. (cherry picked from commit 667f4ed742e0010adb678dff45e004310c4886d4)
Riordan-DC
pushed a commit
to Riordan-DC/godot
that referenced
this pull request
Jan 24, 2023
The issue is caused by godotengine#64306 which makes use of a 3.7 feature while the current recommended python version is 3.5 for 3.x and 3.6 for master. (cherry picked from commit 667f4ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situations where the spawn fix is needed, compiler errors are reported like this because of
Popen
using stream mode by default:In contrast, with this PR, they look like this: