Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "mirror" by "repeat" in doc of ParallaxLayer::motion_mirroring #77174

Merged

Conversation

FranckRJ
Copy link
Contributor

@FranckRJ FranckRJ commented May 17, 2023

Also added a warning explaining that despite its name the texture isn't mirrored.

This may be enough to close #23243.

@FranckRJ FranckRJ requested a review from a team as a code owner May 17, 2023 19:59
Also added a warning explaining that despite its name the texture isn't mirrored.
@FranckRJ FranckRJ force-pushed the improve-parallaxlayer-mirroring-doc branch from 788f4c5 to 4e06f61 Compare May 17, 2023 22:10
@YuriSizov YuriSizov changed the title Replaced "mirror" by "repeat" in doc of ParallaxLayer::motion_mirroring Replace "mirror" by "repeat" in doc of ParallaxLayer::motion_mirroring May 18, 2023
@YuriSizov YuriSizov merged commit e9ba45e into godotengine:master May 18, 2023
@YuriSizov
Copy link
Contributor

Thanks, and congrats on your first merged Godot PR!

@FranckRJ FranckRJ deleted the improve-parallaxlayer-mirroring-doc branch May 18, 2023 20:33
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParallaxLayer mirroring
5 participants