Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Prevent infinite recursion when printing errors #85397

Merged
merged 1 commit into from
Dec 4, 2023
Merged

[Core] Prevent infinite recursion when printing errors #85397

merged 1 commit into from
Dec 4, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Nov 26, 2023 •
edited
Loading

@AThousandShips AThousandShips added bug topic:core crash cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Nov 26, 2023
@AThousandShips AThousandShips added this to the 4.3 milestone Nov 26, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner November 26, 2023 19:20
@AThousandShips AThousandShips mentioned this pull request Nov 26, 2023
Closed
@akien-mga akien-mga merged commit 22f2a6b into godotengine:master Dec 4, 2023
15 checks passed
@AThousandShips AThousandShips deleted the fix_recurse branch December 4, 2023 22:21
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.1.

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 5, 2023
@AThousandShips AThousandShips mentioned this pull request Dec 18, 2023
Closed
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

@AThousandShips AThousandShips mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash topic:core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

EditorLog::add_message error about message queue out of memory triggers infinite error spam and crash
4 participants
@AThousandShips @akien-mga @YuriSizov @bruvzg