-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix property of type Node duplication when script is attached to a child node #87387
Conversation
dcdee1b
to
34799bc
Compare
@AThousandShips is it possible to get this cherry-picked for 4.2? |
I don't know the area well enough to make that call |
Edit: Disregard. |
Can you confirm that this doesn’t happen with a version of godot before my PRs? |
Ah whoops, I didn't pay attention enough to git blame, and thought the relevant code was introduced there. Ignore this. |
34799bc
to
c2576cb
Compare
There is some bug where if you duplicate a node and the duplicated node has its properties updated, the original will also have them changed. aoYq8ZNIt4.mp4 |
c2576cb
to
8a5f788
Compare
@KoBeWi Try again, value now is deeply duplicated so the bug shouldn't happen. |
8a5f788
to
9851c1b
Compare
Fix property of type Node duplication when script is attached to a child node
06abc86
Thanks! |
This is a continuation of a last PR where I seemed to have only partially solved the problem with node duplication as pointed out by one of the comments after the PR got merged.
This PR should hopefully solve the edge case when a script is attached to a child node but the user duplicates that node's parent.