Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCons: Apply generated_wrapper to shader builders #91840

Closed

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented May 11, 2024

Followup to #91624

Next wave of prettified/reformatted generated files is for the .glsl shaders. Kept the scope to just these, because despite having only two build scripts gles3_builders/glsl_builders, they're arguably the most complicated build scripts in the repo. They're certainly the most involved, as they utilize dedicated pytest scripts to ensure their outputs come out as expected; as such, this had to update the *_expected_full.glsl files as well. I also made sure that the pytests properly work on Windows as well (supersedes #86083 in the process).

In addition to the above, two other adjustments were made. The first and more simple of the two is adding .*_cache to .gitignore in order to broadly catch python module cache folders (removed .mypy_cache entry because that's now covered). The second was further expanding the functionality of generated_wrapper, featuring better logic for generating header guards (now its own function) & automatically formatting multiline #define to ensure their \ wrappers are right-justified (also its own function). Documentation has been added to each function as well, hopefully making their intended usage as unambiguous as possible.

@Repiteo Repiteo force-pushed the scons/expand-generated-wrapper branch from 736eb4d to bf1e333 Compare July 2, 2024 18:11
@Repiteo
Copy link
Contributor Author

Repiteo commented Oct 29, 2024

Closing to be re-implemented on a wider scope in the future

@Repiteo Repiteo closed this Oct 29, 2024
@Repiteo Repiteo deleted the scons/expand-generated-wrapper branch October 29, 2024 17:53
@Repiteo Repiteo removed this from the 4.x milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants