docs: ADR-0005 install seam + Origin model (spec 003 groundwork); gitignore specs/#202
Merged
Conversation
Outcome of grilling spec 003 (browser skill management). - ADR-0005: install/update/reindex logic moves into fastskill-core (CLI becomes a thin caller; embedding provider injected at serve startup); one canonical `Origin` type replaces SkillSource(x2), SourceType, and the nine flat SkillDefinition.source_* fields. Greenfield break, no back-compat shim. - CONTEXT.md: add the `Origin` glossary term (and the Origin::repository vs Repository distinction). - .gitignore: specs/ are local working artifacts, not shipped in the repo; untrack the existing specs (they remain on disk + in history). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design groundwork for browser skill management (spec 003), settled via a grilling session. This PR is docs + repo-hygiene only — no code changes (the implementation follows in later phases on this branch).
It also flips how design specs are stored:
specs/becomes a local working artifact rather than shipped in the repo.What's here
docs/adr/0005-install-seam-and-origin-model.md— the architectural spine:fastskill-core; the CLI (execute_add/execute_update/execute_reindex) becomes a thin caller over the same core methods — one path, no drift. The embedding provider is injected atservestartup; the HTTP path returns structured results (no shell-out, no501).UpdateServiceis narrowed to the read-only "what's newer?" query.Originenum (git | local | zip-url | repository) replacesSkillSource(two colliding types),SourceType, and the nine flatSkillDefinition.source_*fields.Origin::repositoryis a reference into a configured Repository, not the Repository itself. Greenfield break, no back-compat shim.CONTEXT.md— new Origin glossary term + theOrigin::repository≠Repositorydistinction..gitignore—specs/are local design artifacts; untrack the existing specs (they remain on disk + in history).Key resolved decisions (from the grill)
install(origin, mode: Fresh|Update); per-variant re-resolve; immutable/editable = honest no-ops409-on-existing-id (even for a different Origin)/reindex→200 skipped(not501) with no providerGET /statusgainswritable+embedding_provider; 403 stays as backstopNote
The rewritten
specs/003-browser-skill-management.mdnow lives on disk only (gitignored), so it is intentionally not in this diff. The ADR + glossary are the committed design record; the implementation phases land on this branch next.Pre-commit checks pass (fmt / clippy
-D warnings/ 658 tests — code unchanged frommain).🤖 Generated with Claude Code