Skip to content

Commit 014fdd1

Browse files
alvinjaisongopherbot
authored andcommitted
cmd/go/internal/cache: fix GODEBUG name in comments
The comments reference GODEBUG=goverifycache=1 but the actual setting name is gocacheverify (as used in the code, tests, and documentation throughout the repository). This typo was introduced in CL 558301a when the Cache interface was abstracted, and the word order was accidentally flipped in three comment locations. Change-Id: Id260923e2f0ccae86e77d6440143a9ab6c5732d4 GitHub-Last-Rev: 5247b5d GitHub-Pull-Request: #80565 Reviewed-on: https://go-review.googlesource.com/c/go/+/805541 Auto-Submit: Sean Liao <sean@liao.dev> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Michael Pratt <mpratt@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Sean Liao <sean@liao.dev>
1 parent 1022c8f commit 014fdd1

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

src/cmd/go/internal/cache/cache.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ type Cache interface {
4848
// the seek position is not guaranteed to be in any particular state.
4949
//
5050
// As a special case, if the ReadSeeker is of type noVerifyReadSeeker,
51-
// the verification from GODEBUG=goverifycache=1 is skipped.
51+
// the verification from GODEBUG=gocacheverify=1 is skipped.
5252
//
5353
// After a successful call to Put, OutputFile(OutputID) must
5454
// exist on disk until Close is called (at the end of the process).
@@ -524,7 +524,7 @@ func (c *DiskCache) putIndexEntry(id ActionID, out OutputID, size int64, allowVe
524524

525525
// noVerifyReadSeeker is an io.ReadSeeker wrapper sentinel type
526526
// that says that Cache.Put should skip the verify check
527-
// (from GODEBUG=goverifycache=1).
527+
// (from GODEBUG=gocacheverify=1).
528528
type noVerifyReadSeeker struct {
529529
io.ReadSeeker
530530
}
@@ -554,7 +554,7 @@ func (c *DiskCache) PutExecutable(id ActionID, name string, file io.ReadSeeker)
554554
}
555555

556556
// PutNoVerify is like Put but disables the verify check
557-
// when GODEBUG=goverifycache=1 is set.
557+
// when GODEBUG=gocacheverify=1 is set.
558558
// It is meant for data that is OK to cache but that we expect to vary slightly from run to run,
559559
// like test output containing times and the like.
560560
func PutNoVerify(c Cache, id ActionID, file io.ReadSeeker) (OutputID, int64, error) {

0 commit comments

Comments
 (0)