Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: TestAfterStop flaky on solaris-amd64-oraclerel #35537

Closed
bcmills opened this issue Nov 12, 2019 · 4 comments
Closed

time: TestAfterStop flaky on solaris-amd64-oraclerel #35537

bcmills opened this issue Nov 12, 2019 · 4 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Nov 12, 2019

--- FAIL: TestAfterStop (0.47s)
    sleep_test.go:244: failed to stop event 0
FAIL
FAIL	time	5.886s

2019-11-12T05:35:33-99957b6/solaris-amd64-oraclerel
2019-10-11T18:07:53-24f9238/solaris-amd64-oraclerel

CC @ianlancetaylor @rorth

@bcmills bcmills added this to the Go1.14 milestone Nov 12, 2019
@bcmills bcmills added the OS-Solaris label Nov 12, 2019
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 15, 2019

Interesting that it failed twice in the same way, once with the old timer implementation and once with the new. The test starts a timer to run for 50 milliseconds and assumes that it will stop the timer before that time is up. I wonder if occasionally on Solaris the test program is suspended for long enough for the timer to fire?

@ianlancetaylor ianlancetaylor modified the milestones: Go1.14, Unplanned Nov 15, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 15, 2019

Change https://golang.org/cl/207457 mentions this issue: time: only fail TestAfterStop if it fails five times in a row

@gopherbot gopherbot closed this in dab1a10 Nov 15, 2019
@rorth

This comment has been minimized.

Copy link

@rorth rorth commented Nov 18, 2019

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 18, 2019

Change https://golang.org/cl/207403 mentions this issue: time: deflake TestTicker

gopherbot pushed a commit that referenced this issue Nov 19, 2019
Take the opportunity of deflaking to make it take less time to run.

Updates #35537

Change-Id: I91ca8094fbe18fbfcd34dfda98da1592c9c82943
Reviewed-on: https://go-review.googlesource.com/c/go/+/207403
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.