Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: README images should be proxied to protect user privacy #37128

Open
ghost opened this issue Feb 7, 2020 · 1 comment
Open

x/pkgsite: README images should be proxied to protect user privacy #37128

ghost opened this issue Feb 7, 2020 · 1 comment

Comments

@ghost
Copy link

@ghost ghost commented Feb 7, 2020

The overview page links directly to images referenced from the readme markdown. These references allow third parties to track users on pkg.go.dev.

Github proxies images referenced from the readme to prevent such tracking. See the following for more information:

pkg.go.dev should do the same.

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/labstack/echo?tab=overview and many other ?tab=overview pages.

What did you do?

I visited the page.

What did you expect to see?

I expected to see requests to pkg.go.dev and it's trusted partners.

What did you see instead?

I saw image requests to sourcegraph.com, img.sheilds.go and goreportcard.com.

@gopherbot gopherbot added this to the Unreleased milestone Feb 7, 2020
@gopherbot gopherbot added the pkgsite label Feb 7, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Feb 14, 2020

/cc @julieqiu per owners.

@julieqiu julieqiu changed the title go.dev: proxy images referenced from overview tab to protect user privacy go.dev: README images should be proxied to protect user privacy Feb 19, 2020
@julieqiu julieqiu changed the title go.dev: README images should be proxied to protect user privacy x/pkgsite: README images should be proxied to protect user privacy Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.