Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: go mod tidy quick fix does not preserve comments #40419

Closed
stamblerre opened this issue Jul 27, 2020 · 1 comment
Closed

x/tools/gopls: go mod tidy quick fix does not preserve comments #40419

stamblerre opened this issue Jul 27, 2020 · 1 comment
Labels
Tools gopls
Milestone
gopls/v0.5.3

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jul 27, 2020

Before:

Screen Shot 2020-07-26 at 7 58 24 PM

After:

Screen Shot 2020-07-26 at 7 58 40 PM

In this case, accepting the fix to remove an unused dependency deleted a comment from the require block.
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Jul 27, 2020
@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Oct 29, 2020

#38209 changed gopls to use the go command when adding/deleting requires, so I think this has been addressed in the best way possible. I believe that comments will still be deleted, but this is also what the go command would do.
@stamblerre stamblerre closed this Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tools gopls
Projects
None yet
Milestone
gopls/v0.5.3
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@stamblerre @gopherbot