Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: can't jump-to-definition on embedded type alias #42254

Closed
findleyr opened this issue Oct 28, 2020 · 1 comment
Closed

x/tools/gopls: can't jump-to-definition on embedded type alias #42254

findleyr opened this issue Oct 28, 2020 · 1 comment

Comments

@findleyr
Copy link
Contributor

@findleyr findleyr commented Oct 28, 2020

Setup:

type T = struct{}

type S struct {
  T
}

var x T

Jump to definition works on the T from var x T, but not on the T embedded in S. I'm sure that this is due to the way go/types handles type aliases, but we should work around this in the syntax layer.

@gopherbot gopherbot added this to the Unreleased milestone Oct 28, 2020
@stamblerre stamblerre added the NeedsFix label Oct 28, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 21, 2020

Change https://golang.org/cl/272186 mentions this issue: internal/lsp: fix godef for embedded type aliases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.