Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io/fs, testing/testfs: disagreement about whether Open(".") must succeed #44310

Open
josharian opened this issue Feb 16, 2021 · 0 comments
Open

io/fs, testing/testfs: disagreement about whether Open(".") must succeed #44310

josharian opened this issue Feb 16, 2021 · 0 comments

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Feb 16, 2021

(Sorry for filing all these right around when 1.16 was released, not before. Just bad luck timing.)

I implemented what I thought was the simplest possible empty filesystem:

func (f *FS) Open(name string) (fs.File, error) {
	return nil, &fs.PathError{Op: "open", Path: name, Err: fs.ErrNotExist}
}

It seems to me that according to the io/fs docs, this is a valid empty filesystem.

testing/fstest.TestFS doesn't like it, though:

--- FAIL: TestEmptyFS (0.01s)
    fs_test.go:10: TestFS found errors:
        .: Open: open .: file does not exist

Is TestFS wrong? Or are there missing docs requiring the file "." to be openable?

cc @rsc

P.S. golang.org/s/owners doesn't list any owners for io/fs and testing/fstest.

@toothrot toothrot added this to the Backlog milestone Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants