Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: better error message on bad path #45992

Open
jba opened this issue May 6, 2021 · 1 comment
Open

x/pkgsite: better error message on bad path #45992

jba opened this issue May 6, 2021 · 1 comment
Labels
NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
pkgsite/unplanned

Comments

@jba
Copy link
Contributor

jba commented May 6, 2021

https://pkg.go.dev/github.com/gomarkdown displays a page that just says "400 Bad Request". It should say more about the problem.
@jba jba added NeedsFix The path to resolution is known, but the work has not been done. pkgsite labels May 6, 2021
@jba jba added this to the pkgsite/unplanned milestone May 6, 2021
@jba jba self-assigned this May 6, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/317589 mentions this issue: internal/frontend: improve "bad request" error messages

gopherbot pushed a commit to golang/pkgsite that referenced this issue May 6, 2021
@jba
internal/frontend: improve "bad request" error messages
69a1222 
Instead of "400 BadRequest", display an error message that helps the
user understand the problem.

For golang/go#45992

Change-Id: I927654cc126a94e0464b23f2df795561a1913a99
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/317589
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
@rsc rsc unassigned jba Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
2 participants
@gopherbot @jba