Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: examples don't properly run for preview release modules #46689

Open
codyoss opened this issue Jun 10, 2021 · 2 comments
Open

x/pkgsite: examples don't properly run for preview release modules #46689

codyoss opened this issue Jun 10, 2021 · 2 comments

Comments

@codyoss
Copy link
Member

@codyoss codyoss commented Jun 10, 2021

What did you do?

Went to run the WithLabels example.

What did you expect to see?

A runnable example.

What did you see instead?

The following error in output:

go: finding module for package cloud.google.com/go/logging/jsonlog
go: downloading cloud.google.com/go/logging v1.4.2
go: downloading cloud.google.com/go v0.84.0
prog.go:4:2: module cloud.google.com/go/logging@latest found (v1.4.2), but does not contain package cloud.google.com/go/logging/jsonlog

Additional Context

  • This is likely to to this being based off a pre-release tag: cloud.google.com/go/logging@v1.5.0-jsonlog-preview.
  • This example does not actually produce any meaningful output, just noticed the error when I had click on it.
@gopherbot gopherbot added this to the Unreleased milestone Jun 10, 2021
@jamalc jamalc removed this from the Unreleased milestone Jun 12, 2021
@jamalc jamalc added this to the pkgsite/unplanned milestone Jun 12, 2021
@jamalc
Copy link

@jamalc jamalc commented Jun 12, 2021

We could disable or hide the run button for examples are not runnable or show a message in the output box that says as much. What do you think @julieqiu?

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jun 15, 2021

Both make sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants