Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: On "Tutorial: Get started with Go" there is outdated information about the 'quote' package #51188

Open
haroldlbrown opened this issue Feb 14, 2022 · 4 comments
Labels
Documentation NeedsFix
Milestone

Comments

@haroldlbrown
Copy link

@haroldlbrown haroldlbrown commented Feb 14, 2022

What is the URL of the page with the issue?

https://go.dev/doc/tutorial/getting-started

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/98.0.4758.80 Safari/537.36

Screenshot

image

What did you do?

Visited https://go.dev/doc/tutorial/getting-started

What did you expect to see?

Up-to-date information about the rsc.io/quote package

What did you see instead?

In the tutorial there is talk about a rsc.io/quote/v3 version of the quote package.
However, when I search for the quote package on https://pkg.go.dev/search?q=quote, the only thing that I can find is https://pkg.go.dev/rsc.io/quote/v4.

@gopherbot gopherbot added this to the Unreleased milestone Feb 14, 2022
@dmitshur dmitshur added the NeedsInvestigation label Feb 14, 2022
@thepudds
Copy link

@thepudds thepudds commented Feb 14, 2022

Hi @haroldlbrown thanks for the report.

From a quick look, it does look like the tutorial should get a tweak so that the description there aligns better with the current pkg.go.dev behavior.

That said, this might also be an occurrence of #35671 (perhaps as a deliberate test), in which case there is at least some chance that pkg.go.dev will stop mentioning v4.

Even so, I think the text in the tutorial could be updated. The text seems more aligned with older behavior as far as I can tell, such as from this snapshot from 2021 via the web archive:

https://web.archive.org/web/20210409134553/https://pkg.go.dev/search?q=quote

image

CC @stevetraut @julieqiu

@thepudds
Copy link

@thepudds thepudds commented Feb 14, 2022

Hi @stevetraut, if you think the tutorial should be updated, I would be interested in sending a CL.

@bcmills
Copy link
Member

@bcmills bcmills commented Feb 14, 2022

@thepudds, if you'd like to send a fix I can review. Thanks!

@dmitshur dmitshur added NeedsFix Documentation and removed NeedsInvestigation labels Feb 14, 2022
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 22, 2022

Change https://go.dev/cl/394817 mentions this issue: _content/doc/tutorial: update getting started for new pkgsite search

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation NeedsFix
Projects
None yet
Development

No branches or pull requests

5 participants