Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/internal: module asm appears multiple times in workspace #57769

Closed
prattmic opened this issue Jan 12, 2023 · 2 comments
Closed

crypto/internal: module asm appears multiple times in workspace #57769

prattmic opened this issue Jan 12, 2023 · 2 comments
Assignees
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@prattmic
Copy link
Member

Running go work init && go work use -r . in the Go repo results in an unusable workspace:

$ go build std
go: module asm appears multiple times in workspace

src/crypto/internal/bigmod/_asm and src/crypto/internal/edwards25519/field/_asm are the two modules named asm. These should probably have unique names to avoid breaking builds.

cc @FiloSottile


Context: I don't actually particularly want to use a workspace of all modules in the go repo. I am generating cross-references for https://cs.opensource.google/go, and I want nested modules (like golang.org/x/tools/gopls) included. go work use -r . is a simple way to achieve that, and it seems silly to need a special case for the go repo when we could make this just work.

@prattmic prattmic added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 12, 2023
@prattmic prattmic added this to the Go1.21 milestone Jan 12, 2023
@prattmic prattmic self-assigned this Jan 12, 2023
@gopherbot
Copy link

Change https://go.dev/cl/461896 mentions this issue: all: give nested modules fully-qualified names

@gopherbot
Copy link

Change https://go.dev/cl/461942 mentions this issue: go/expect: remove invalid characters from test module path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

2 participants