You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It routinely takes eglot 13s to apply an extract-method fix that is almost instant in VS Code. (This happens even when the ApplyFix downcall has been patched to set async: true.) The server's computation of the diff is fast but the client's application of the diff is slow. Clearly something is amiss in eglot. The task of this issue is to identify the cause and file an upstream bug, because whatever it is likely affects a number of other eglot operations as well.
seankhliao
changed the title
gopls: extract-method is slow in eglot (but not VS Code)
x/tools/gopls: extract-method is slow in eglot (but not VS Code)
Dec 8, 2023
gopherbot
added
the
Tools
This label describes issues relating to any tools in the x/tools repository.
label
Dec 8, 2023
It routinely takes eglot 13s to apply an extract-method fix that is almost instant in VS Code. (This happens even when the ApplyFix downcall has been patched to set async: true.) The server's computation of the diff is fast but the client's application of the diff is slow. Clearly something is amiss in eglot. The task of this issue is to identify the cause and file an upstream bug, because whatever it is likely affects a number of other eglot operations as well.
(For the sake of reproducibility, I was extracting the block at L1175 of the https://go-review.git.corp.google.com/c/tools/+/531695/1/internal/refactor/inline/inline.go.)
The text was updated successfully, but these errors were encountered: