Skip to content

x/tools/gopls: extract-method is slow in eglot (but not VS Code) #63286

@adonovan

Description

@adonovan

It routinely takes eglot 13s to apply an extract-method fix that is almost instant in VS Code. (This happens even when the ApplyFix downcall has been patched to set async: true.) The server's computation of the diff is fast but the client's application of the diff is slow. Clearly something is amiss in eglot. The task of this issue is to identify the cause and file an upstream bug, because whatever it is likely affects a number of other eglot operations as well.

(For the sake of reproducibility, I was extracting the block at L1175 of the https://go-review.git.corp.google.com/c/tools/+/531695/1/internal/refactor/inline/inline.go.)

Metadata

Metadata

Assignees

Labels

ToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions