regexp/syntax: use min func #63350

qiulaidongfeng · 2023-10-03T10:30:41Z

No description provided.

gopherbot · 2023-10-03T10:42:18Z

This PR (HEAD: 6d1a6f6) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/532218.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-10-03T10:50:33Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/532218.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-03T10:58:53Z

Message from qiulaidongfeng:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/532218.
After addressing review feedback, remember to publish your drafts!

Change-Id: I34d528461db3d9ba83d5118744c399a13bfeaefa

gopherbot · 2023-10-03T14:22:10Z

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/532218.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-03T14:22:20Z

This PR (HEAD: fba371d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/532218.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-10-03T14:37:39Z

Message from qiulaidongfeng:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/532218.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-03T16:19:01Z

Message from Ian Lance Taylor:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/532218.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-03T16:19:02Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-10-03T15:58:45Z","revision":"88d2032ba00fb2d419a10e5bfdb015d1f58719fc"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/532218.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-03T16:33:22Z

Message from Ian Lance Taylor:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/532218.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-03T16:33:23Z

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/532218.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-03T16:33:24Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/532218.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-03T19:31:55Z

Message from Ian Lance Taylor:

Patch Set 2: Auto-Submit+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/532218.
After addressing review feedback, remember to publish your drafts!

Change-Id: I679c906057577d4a795c07a2f572b969c3ee14d5 GitHub-Last-Rev: fba371d GitHub-Pull-Request: #63350 Reviewed-on: https://go-review.googlesource.com/c/go/+/532218 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com>

gopherbot · 2023-10-03T19:58:38Z

This PR is being closed because golang.org/cl/532218 has been merged.

text-embedding-004 is deprecated and will stop working in January 2026, so switch to gemini-embedding-001. The results are better in some ways and worse in others. They should work about the same for the related issues feature, although we may want to adjust the thresholds after a few days of seeing how the new embeddings do for real usage. Before: > regexp issue about adding iterators ^D 0.67100 golang/go#61902 # proposal: regexp: add iterator forms of matching methods 0.67000 golang/go#351 # Regexp can't handle lazy quantifiers 0.66900 golang/go#43332 # regexp: Repeated capture groups only capturing final captured match. 0.66300 golang/go#64108 # regexp: Documentation doesn't mention that (?<name>...) capturing group syntax isn't currently supported 0.65500 golang/go#56507 # regexp: improve Regexp.ReplaceAll documentation and tests related to Expand part > proposal: regexp: add iterator forms of matching methods ^D 0.75600 golang/go#61902 # proposal: regexp: add iterator forms of matching methods 0.67000 golang/go#21463 # proposal: regexp: Optimize fixed-length patterns 0.66700 golang/go#54047 # proposal: Go 2: add a new iterator syntax, package, interfaces 0.66100 golang/go#43557 # proposal: Go 2: function values as iterators 0.65500 golang/go#65742 # proposal: Go 2: range-over-function + range over types implementing iterator interface > We propose to add methods to regexp that allow iterating over matches instead of having to accumulate all the matches into a slice. This is one of a collection of proposals updating the standard library for the new 'range over function' feature (#61405). It would only be accepted if that proposal is accepted. See golang/oscar#61897 for a list of related proposals. Regexp has a lot of methods that return slices of all matches (the “FindAll*” methods). Each should have an iterator equivalent that doesn’t build the slice. They can be named by removing the “Find” prefix. The docs would change as follows. (Plain text is unchanged; strikethrough is removed, bold is added): ^D 0.86400 golang/go#61902 # proposal: regexp: add iterator forms of matching methods 0.71700 https://go.dev/wiki/RangefuncExperiment#can-you-provide-more-motivation-for-range-over-functions # Go Wiki: Rangefunc Experiment > Can you provide more motivation for range over functions? 0.69100 golang/go#61901 # bytes, strings: add iterator forms of existing functions 0.68800 golang/go#61899 # slices: add iterator-related functions 0.68200 https://go.dev/pkg/regexp/?m=old#Regexp.FindAll # Package regexp > type Regexp > func (*Regexp) FindAll After: > regexp issue about adding iterators ^D 0.76400 golang/go#50650 # regexp: add the missing is 0.71900 golang/go#17146 # How about add MatchStrings() in regexp meet match string more than one? 0.71200 golang/go#56973 # regexp: add comment in example test describing tricky behavior 0.69700 golang/go#61902 # proposal: regexp: add iterator forms of matching methods 0.69500 golang/go#63350 # regexp/syntax: use min func > proposal: regexp: add iterator forms of matching methods ^D 0.87400 golang/go#61902 # proposal: regexp: add iterator forms of matching methods 0.77400 golang/go#61901 # bytes, strings: add iterator forms of existing functions 0.76400 golang/go#24208 # proposal: regexp: Add functions to the Regexp type to ease accessing named capture groups 0.76300 golang/go#32881 # regexp: Named captures should appear in a hashmap 0.76000 golang/go#66631 # proposal: reflect: Add Type.Fields() iter.Seq[StructField] and Type.Methods() iter.Seq[Method] > We propose to add methods to regexp that allow iterating over matches instead of having to accumulate all the matches into a slice. This is one of a collection of proposals updating the standard library for the new 'range over function' feature (#61405). It would only be accepted if that proposal is accepted. See golang/oscar#61897 for a list of related proposals. Regexp has a lot of methods that return slices of all matches (the “FindAll*” methods). Each should have an iterator equivalent that doesn’t build the slice. They can be named by removing the “Find” prefix. The docs would change as follows. (Plain text is unchanged; strikethrough is removed, bold is added): ^D 0.94900 golang/go#61902 # proposal: regexp: add iterator forms of matching methods 0.86200 golang/go#61901 # bytes, strings: add iterator forms of existing functions 0.83600 golang/go#61899 # slices: add iterator-related functions 0.83100 golang/go#61897 # iter: new package for iterators 0.81100 golang/go#62113 # proposal: x/net/html: add Node.All(), Node.ChildNodes(), Nodes.Parents() iterators Change-Id: Ic6ce353588b62ba7bae12562378b012d18e5feb2 Reviewed-on: https://go-review.googlesource.com/c/oscar/+/708880 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Tatiana Bradley <tatianabradley@google.com>

regexp/syntax: use min func

fba371d

Change-Id: I34d528461db3d9ba83d5118744c399a13bfeaefa

qiulaidongfeng force-pushed the syntax-min branch from 6d1a6f6 to fba371d Compare October 3, 2023 14:17

gopherbot closed this Oct 3, 2023

regexp/syntax: use min func #63350

regexp/syntax: use min func #63350

Uh oh!

Conversation

qiulaidongfeng commented Oct 3, 2023

Uh oh!

gopherbot commented Oct 3, 2023

Uh oh!

gopherbot commented Oct 3, 2023

Uh oh!

gopherbot commented Oct 3, 2023

Uh oh!

gopherbot commented Oct 3, 2023

Uh oh!

gopherbot commented Oct 3, 2023

Uh oh!

gopherbot commented Oct 3, 2023

Uh oh!

gopherbot commented Oct 3, 2023

Uh oh!

gopherbot commented Oct 3, 2023

Uh oh!

gopherbot commented Oct 3, 2023

Uh oh!

gopherbot commented Oct 3, 2023

Uh oh!

gopherbot commented Oct 3, 2023

Uh oh!

gopherbot commented Oct 3, 2023

Uh oh!

gopherbot commented Oct 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants