Skip to content

x/pkgsite: source file links for unknown hosts should not link to self #73333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
runxiyu opened this issue Apr 11, 2025 · 4 comments
Open

x/pkgsite: source file links for unknown hosts should not link to self #73333

runxiyu opened this issue Apr 11, 2025 · 4 comments
Labels
BugReport Issues describing a possible bug in the Go implementation. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone

Comments

@runxiyu
Copy link

runxiyu commented Apr 11, 2025

What is the URL of the page with the issue?

https://pkg.go.dev/go.lindenii.runxiyu.org/forge@v0.1.41/forged/cmd/forge

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64; rv:120.0) Gecko/20100101 Firefox/120.0

Screenshot

Image

What did you do?

I host some projects on an uncommon software forge.

Tree links are like /tree/dir/dir/file appended to the repo root.

What did you see happen?

The View all Source files and main.go anchors refer back to the same page on pkgsite.

What did you expect to see?

Both links are removed or greyed out to indicate that pkgsite does not know the URL scheme of the forge.

See also: #69638

@gopherbot gopherbot added this to the Unreleased milestone Apr 11, 2025
@seankhliao seankhliao changed the title x/pkgsite: Hide source links x/pkgsite: source file links for unknown hosts should not link to self Apr 11, 2025
@gabyhelp
Copy link

Related Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@gabyhelp gabyhelp added the FeatureRequest Issues asking for a new feature that does not need a proposal. label Apr 11, 2025
@runxiyu
Copy link
Author

runxiyu commented Apr 11, 2025

@gabyhelp I believe that this should be considered a bug rather than a feature request.

@prattmic prattmic added BugReport Issues describing a possible bug in the Go implementation. and removed FeatureRequest Issues asking for a new feature that does not need a proposal. labels Apr 14, 2025
@prattmic
Copy link
Member

cc @golang/pkgsite

@prattmic prattmic added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 15, 2025
@ansaba
Copy link

ansaba commented Apr 17, 2025

cc: @jba
Reference : #40477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BugReport Issues describing a possible bug in the Go implementation. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Development

No branches or pull requests

5 participants