-
Notifications
You must be signed in to change notification settings - Fork 18.6k
Closed
Labels
BackportIssues created for requesting a backport of a change to a previous Go version.Issues created for requesting a backport of a change to a previous Go version.CherryPickApprovedUsed during the release process for point releasesUsed during the release process for point releasescompiler/runtimeIssues related to the Go compiler and/or runtime.Issues related to the Go compiler and/or runtime.
Milestone
Description
@randall77 requested issue #71302 to be considered for backport to the next 1.23 minor release.
Ok, that's good. I'll get that CL in soon.
I think the remaining question is, should we backport?
In favor:
- This could cause really weird behavior and/or corruption on darwin/amd64. There is only one stdlib call affected (
syscall/Getnameinfo), but several inx.sys(Connectxfor freebsd,mmapfor netbsd, dragonfly).darwin/amd64is a first-class port.In opposition:
- This has always been broken (since introduced in late 2022). It is not a regression from 1.24.
- Only the
Connectxfailure has been noticed.I'm leaning towards backporting. The fix is pretty simple and the unfixed behavior is very hard to debug and/or work around.
@gopherbot please open backport issues
Metadata
Metadata
Assignees
Labels
BackportIssues created for requesting a backport of a change to a previous Go version.Issues created for requesting a backport of a change to a previous Go version.CherryPickApprovedUsed during the release process for point releasesUsed during the release process for point releasescompiler/runtimeIssues related to the Go compiler and/or runtime.Issues related to the Go compiler and/or runtime.