access: approvers

[thepudds]

I would like to request +2 approvers access on Gerrit.

The main reasons are:

1. I'd like to do more gardening in Gerrit.

2. Being able to submit my own CLs would help me a fair amount (especially being able to watch them land, knowing better when I should be available, being able to spot check after something lands, and so on).

3. Maybe 18 months ago or so, I created a little rules engine that runs in GerritBot for automatically doing a basic review in Gerrit for PRs from GitHub (#61573), and around that time I also did maybe a dozen or so other things to smooth that process out from the maintainer side as well as for the contributors (e.g., comment from Bryan here). I would like to do a bit more here, and it would be helpful to more clearly see the +2 reviewer side.

4. I think I can help with some reviews. (For example, Keith has recently been kind enough to add me as a reviewer on some of his recent compiler optimizations for avoiding user allocations -- for some of those, I'd probably just do a +1, but for others, I'd feel comfortable doing a +2, and there are other areas where I think I could help).

5. I currently have a minor problem that multiple people on the core team have said they assumed I already have +2 access, which has led to situations multiple times where they are politely waiting for me to submit my CL while I am politely waiting for them 😅.

The main email address I have used in Gerrit is thepudds1460@gmail.com. I've used other email addresses though, including an early throwaway address that I would need to dig up. This search should find most of my CLs, minus some of the earliest:

https://go-review.googlesource.com/q/author:*thepudds*+OR+owner:*thepudds*

I've been a member of the Go GitHub organization for many years now, but when I first started to contribute to the Go project, I was not positioned to sign a CLA, so I ended up contributing in other ways, including helping different people troubleshoot their issues, and trying to drain some of the drama out of some otherwise heated conversations on the issue tracker & elsewhere (especially in the early days of Go modules), and it turns out I'm currently the top listed committer for content for the Go wiki 😅.

Looking over the criteria listed at GerritAccess, I will say that I do care about Go and I do want to help it succeed.

See https://go.dev/wiki/GerritAccess.

CC @dmitshur, @mknyszek, @prattmic

[gabyhelp]

Related Issues

• access: running TryBots #56854 (closed)
• access: approvers #66611 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[mknyszek]

Hi @thepudds,

Thank you for contributing to the Go project and all of your work throughout the project, including on GitHub. We've discussed this request on the team and agreed to grant you this access. I've added you to the approvers group now.

Please be familiar with the rules for voting and submitting changes as described at https://go.dev/wiki/GerritAccess#approving-cls-approvers. If you're unsure or have any questions, please don't hesitate to ask us.

Thank you again for contributing, your help is greatly appreciated!