x/tools/gopls: vulncheck "unsaved files" check is not working reliably

[adonovan]

Running the latest gopls with VS Code, I notice that invoking the "Run vulncheck" code lens attached to the module declaration of gopls/go.mod, while gopls/main.go has unsaved edits, does not reliably cause the server to report an "All files must be saved first" error, despite the appearance of correct logic to this end in server.commandHandler.run. We should investigate.

(I found this while investigating a different bug, in which I saw the "unsaved" error in VS Code, saved the main.go file, then re-ran the code lens command, only to see a "Vulncheck is already running bug". But now I can't reproduce that bug because I don't get the "unsaved" error at all.)

cc: @ethanalee-work

[gabyhelp]

Related Issues

• x/tools/gopls: toggling vulncheck does not clear diagnostics #60574 (closed)
• x/tools/gopls: add conditional vulncheck IDE support #75447
• x/tools/gopls: reset diagnostics when toggling vulncheck on/off #60465 (closed)
• x/tools/gopls: add analyzer for vulnerability check #50577 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}