New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: detect leftover temporary files? #9806

Open
minux opened this Issue Feb 8, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@minux
Member

minux commented Feb 8, 2015

Could the builders detect that there isn't any leftover temporary
files in $TMPDIR after testing each repo? (We need to whitelist
a few, for example gopath-api-*)

Ideally this should be treated a build failure and reported back
to the CL that triggered this.

Each time I logged into the netbsd-386 builder, I find a lot
temporary files in /tmp. However, as I don't know which build
generated them, I have to manually check if the bug is still
there.

@minux minux added the repo-build label Feb 8, 2015

@bradfitz

This comment has been minimized.

Member

bradfitz commented Feb 8, 2015

Yes, we could do something like this. Maybe we add a new flag to the buildlet exec handler like "?detect-tmp-leak=1" and if so, it scans tmp before & after the run, and only complains if the command exited with success and any files in $TMPDIR (or equivalent) are new from the beginning of the run.

/cc @adg

@minux

This comment has been minimized.

Member

minux commented Feb 8, 2015

@bradfitz

This comment has been minimized.

Member

bradfitz commented Feb 8, 2015

SGTM

@minux

This comment has been minimized.

Member

minux commented Feb 8, 2015

@rsc rsc added this to the Unplanned milestone Apr 10, 2015

@rsc rsc changed the title from builder: detect leftover temporary files? to x/build: detect leftover temporary files? Apr 14, 2015

@rsc rsc removed the repo-build label Apr 14, 2015

@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015

@rsc rsc added the Builders label Jun 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment