-
Notifications
You must be signed in to change notification settings - Fork 18.5k
bufio: avoid rescanning buffer multiple times in ReadSlice #25441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR (HEAD: 11be550) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/113535 to see it. Tip: You can toggle comments from me using the |
|
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/113535. |
|
Message from Dave Cheney: Patch Set 1: Code-Review-1 Thank you for this change. The development tree is currently frozen ahead of the 1.11 release [0]. To proceed with this change please consider the following suggestions a. if this change is response to an issue targeted at Go 1.11, please include the text "fixes #NNN" where NNN is the issue this change relates to [1]. 0: https://github.com/golang/go/wiki/Go-Release-Cycle
Please don’t reply on this GitHub thread. Visit golang.org/cl/113535. |
|
This PR (HEAD: 63d9f84) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/113535 to see it. Tip: You can toggle comments from me using the |
|
Message from Andrius Lukas Narbutas: Patch Set 2:
Thanks for information. Please don’t reply on this GitHub thread. Visit golang.org/cl/113535. |
When existing data in buffer does not have delimiter, and new data is added with b.fill(), continue search from previous point instead of starting from beginning.
|
This PR (HEAD: 08e7d2f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/113535 to see it. Tip: You can toggle comments from me using the |
e4259d6 to
6dbaf03
Compare
9092511 to
95c3348
Compare
0090c13 to
8fbbf63
Compare
|
Message from Gerrit User 5065: Patch Set 4: Patch Set 3 was rebased Please don’t reply on this GitHub thread. Visit golang.org/cl/113535. |
|
Message from Gerrit User 5065: Patch Set 4: Run-TryBot+1 I'll let Ian or Robert decide on this one. Seems fine, but without performance numbers I can't be sure how much it's worth any additional complexity. Please don’t reply on this GitHub thread. Visit golang.org/cl/113535. |
|
Message from Gerrit User 5976: Patch Set 4: TryBots beginning. Status page: https://farmer.golang.org/try?commit=c6bac192 Please don’t reply on this GitHub thread. Visit golang.org/cl/113535. |
|
Message from Gerrit User 5976: Patch Set 4: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/113535. |
|
This PR is being closed because golang.org/cl/113535 has been merged. |
When existing data in buffer does not have delimiter, and new data is added with b.fill(), continue search from previous point instead of starting from beginning. Change-Id: Id78332afe2b0281b4a3c86bd1ffe9449cfea7848 GitHub-Last-Rev: 08e7d2f GitHub-Pull-Request: #25441 Reviewed-on: https://go-review.googlesource.com/113535 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
When existing data in buffer does not have delimiter,
and new data is added with b.fill(), continue search from
previous point instead of starting from beginning.