Skip to content

Conversation

@andrius4669
Copy link
Contributor

When existing data in buffer does not have delimiter,
and new data is added with b.fill(), continue search from
previous point instead of starting from beginning.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label May 17, 2018
@gopherbot
Copy link
Contributor

This PR (HEAD: 11be550) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/113535 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/113535.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dave Cheney:

Patch Set 1: Code-Review-1

Thank you for this change. The development tree is currently frozen ahead of the 1.11 release [0]. To proceed with this change please consider the following suggestions

a. if this change is response to an issue targeted at Go 1.11, please include the text "fixes #NNN" where NNN is the issue this change relates to [1].
b. if this is a performance improvement, please include benchmark results using benchcmp [2] showing the potential improvements this change makes. Please be aware that this change may not be accepted during the Go 1.11 code freeze.

0: https://github.com/golang/go/wiki/Go-Release-Cycle

  1. https://golang.org/doc/contribute.html#commit_changes
  2. https://godoc.org/golang.org/x/tools/cmd/benchcmp

Please don’t reply on this GitHub thread. Visit golang.org/cl/113535.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 63d9f84) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/113535 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Andrius Lukas Narbutas:

Patch Set 2:

Patch Set 1: Code-Review-1

Thank you for this change. The development tree is currently frozen ahead of the 1.11 release [0]. To proceed with this change please consider the following suggestions

a. if this change is response to an issue targeted at Go 1.11, please include the text "fixes #NNN" where NNN is the issue this change relates to [1].
b. if this is a performance improvement, please include benchmark results using benchcmp [2] showing the potential improvements this change makes. Please be aware that this change may not be accepted during the Go 1.11 code freeze.

0: https://github.com/golang/go/wiki/Go-Release-Cycle

  1. https://golang.org/doc/contribute.html#commit_changes
  2. https://godoc.org/golang.org/x/tools/cmd/benchcmp

Thanks for information.
This should be performance improvement, I'll try benchmarking it.


Please don’t reply on this GitHub thread. Visit golang.org/cl/113535.
After addressing review feedback, remember to publish your drafts!

When existing data in buffer does not have delimiter,
and new data is added with b.fill(), continue search from
previous point instead of starting from beginning.
@gopherbot
Copy link
Contributor

This PR (HEAD: 08e7d2f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/113535 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot gopherbot force-pushed the master branch 2 times, most recently from e4259d6 to 6dbaf03 Compare May 31, 2018 18:23
@gopherbot gopherbot force-pushed the master branch 20 times, most recently from 9092511 to 95c3348 Compare July 19, 2018 18:17
@gopherbot gopherbot force-pushed the master branch 6 times, most recently from 0090c13 to 8fbbf63 Compare July 28, 2018 01:16
@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 4: Patch Set 3 was rebased


Please don’t reply on this GitHub thread. Visit golang.org/cl/113535.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 4: Run-TryBot+1

I'll let Ian or Robert decide on this one.

Seems fine, but without performance numbers I can't be sure how much it's worth any additional complexity.


Please don’t reply on this GitHub thread. Visit golang.org/cl/113535.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=c6bac192


Please don’t reply on this GitHub thread. Visit golang.org/cl/113535.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 4: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/113535.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/113535 has been merged.

@gopherbot gopherbot closed this Aug 22, 2018
gopherbot pushed a commit that referenced this pull request Aug 22, 2018
When existing data in buffer does not have delimiter,
and new data is added with b.fill(), continue search from
previous point instead of starting from beginning.

Change-Id: Id78332afe2b0281b4a3c86bd1ffe9449cfea7848
GitHub-Last-Rev: 08e7d2f
GitHub-Pull-Request: #25441
Reviewed-on: https://go-review.googlesource.com/113535
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants