Skip to content

doc: fixed some links #31914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LorenzNickel wants to merge 2 commits into from
Closed

doc: fixed some links #31914

LorenzNickel wants to merge 2 commits into from

Conversation

@LorenzNickel
Copy link
Contributor

@LorenzNickel LorenzNickel commented May 8, 2019

No description provided.

Lorenz Nickel added 2 commits May 8, 2019 17:58
link: fixed url because file was deleted
cac6ddc 
The URL is not reachable and this seems to be the last version where this file was available
link: fixed url because website is not accessible
0dae408 
The old link was hosted on a website, which is no longer accessible. The new link seems to be a reputable website hosting the same file
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label May 8, 2019
@gopherbot
Copy link
Contributor

gopherbot commented May 8, 2019

This PR (HEAD: 0dae408) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/176017 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented May 8, 2019

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/176017.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request May 8, 2019
@bradfitz
doc: fixed some links
bef1534 
Change-Id: I8563a20a4ba43cee7d4b73377c405a6ff12636e5
GitHub-Last-Rev: 0dae408
GitHub-Pull-Request: #31914
Reviewed-on: https://go-review.googlesource.com/c/go/+/176017
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link
Contributor

gopherbot commented May 8, 2019

This PR is being closed because golang.org/cl/176017 has been merged.

@gopherbot gopherbot closed this May 8, 2019
FiloSottile pushed a commit to FiloSottile/nistec that referenced this pull request May 13, 2022
@bradfitz
doc: fixed some links
54af26c 
Change-Id: I8563a20a4ba43cee7d4b73377c405a6ff12636e5
GitHub-Last-Rev: 0dae408845c7cf42667a65fff6f7d1a382e2d320
GitHub-Pull-Request: golang/go#31914
Reviewed-on: https://go-review.googlesource.com/c/go/+/176017
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
bassosimone pushed a commit to ooni/oocrypto that referenced this pull request May 21, 2022
@bradfitz
doc: fixed some links
0a12ee9 
Change-Id: I8563a20a4ba43cee7d4b73377c405a6ff12636e5
GitHub-Last-Rev: 0dae408845c7cf42667a65fff6f7d1a382e2d320
GitHub-Pull-Request: golang/go#31914
Reviewed-on: https://go-review.googlesource.com/c/go/+/176017
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LorenzNickel @gopherbot @googlebot