net/http/httptest: remove unnecessary creation of http.Transport #60124

ZekeLu · 2023-05-11T03:28:10Z

In (*Server).StartTLS, it's unnecessary to create an http.Client
with a Transport, because a new one will be created with the
TLSClientConfig later.

gopherbot · 2023-05-11T03:34:30Z

This PR (HEAD: a3facfc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/494355 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

mimani68

Sound current modification could helps to improve performance.

Why is test result?

ZekeLu · 2023-05-14T11:59:47Z

Why is test result?

Sorry, but I don't understand your question. Can you elaborate the question?

And please note that the golang project uses Gerrit for code review.

gopherbot · 2023-05-15T17:11:34Z

Message from Damien Neil:

Patch Set 1: Auto-Submit+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/494355.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-28T13:36:20Z

Message from qiulaidongfeng:

Patch Set 1: Code-Review+1 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/494355.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-28T13:43:18Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/494355.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-28T13:43:18Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/494355.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-28T13:50:24Z

Message from Gopher Robot:

Patch Set 1: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/494355.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-29T05:16:59Z

This PR (HEAD: bb7e510) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/494355.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-01T11:03:37Z

Message from qiulaidongfeng:

Patch Set 2: Code-Review+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/494355.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-01T11:03:38Z

Message from Gopher Robot:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/494355.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-01T11:16:30Z

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/494355.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-01T11:22:57Z

Message from Gopher Robot:

Patch Set 2: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/494355.
After addressing review feedback, remember to publish your drafts!

In (*Server).StartTLS, it's unnecessary to create an http.Client with a Transport, because a new one will be created with the TLSClientConfig later.

gopherbot · 2023-11-01T13:47:26Z

This PR (HEAD: 3372459) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/494355.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-01T13:53:59Z

Message from Zeke Lu:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/494355.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-01T13:54:00Z

Message from t hepudds:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/494355.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-01T13:54:01Z

Message from t hepudds:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/494355.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-01T14:00:30Z

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/494355.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-01T14:07:07Z

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/494355.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-04T02:31:10Z

Message from qiulaidongfeng:

Patch Set 3: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/494355.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-06T18:11:19Z

Message from Heschi Kreinick:

Patch Set 3: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/494355.
After addressing review feedback, remember to publish your drafts!

In (*Server).StartTLS, it's unnecessary to create an http.Client with a Transport, because a new one will be created with the TLSClientConfig later. Change-Id: I086e28717e9739787529006c3f0296c8224cd790 GitHub-Last-Rev: 3372459 GitHub-Pull-Request: #60124 Reviewed-on: https://go-review.googlesource.com/c/go/+/494355 Run-TryBot: t hepudds <thepudds1460@gmail.com> Reviewed-by: Heschi Kreinick <heschi@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: qiulaidongfeng <2645477756@qq.com>

gopherbot · 2023-11-06T21:28:23Z

This PR is being closed because golang.org/cl/494355 has been merged.

mimani68 approved these changes May 14, 2023

View reviewed changes

ZekeLu force-pushed the httptest-StartTLS branch from a3facfc to bb7e510 Compare October 29, 2023 05:15

net/http/httptest: remove unnecessary creation of http.Transport

3372459

In (*Server).StartTLS, it's unnecessary to create an http.Client with a Transport, because a new one will be created with the TLSClientConfig later.

ZekeLu force-pushed the httptest-StartTLS branch from bb7e510 to 3372459 Compare November 1, 2023 13:42

gopherbot closed this Nov 6, 2023

net/http/httptest: remove unnecessary creation of http.Transport #60124

net/http/httptest: remove unnecessary creation of http.Transport #60124

Uh oh!

Conversation

ZekeLu commented May 11, 2023

Uh oh!

gopherbot commented May 11, 2023

Uh oh!

mimani68 left a comment

Choose a reason for hiding this comment

Uh oh!

ZekeLu commented May 14, 2023

Uh oh!

gopherbot commented May 15, 2023

Uh oh!

gopherbot commented Oct 28, 2023

Uh oh!

gopherbot commented Oct 28, 2023

Uh oh!

gopherbot commented Oct 28, 2023

Uh oh!

gopherbot commented Oct 28, 2023

Uh oh!

gopherbot commented Oct 29, 2023

Uh oh!

gopherbot commented Nov 1, 2023

Uh oh!

gopherbot commented Nov 1, 2023

Uh oh!

gopherbot commented Nov 1, 2023

Uh oh!

gopherbot commented Nov 1, 2023

Uh oh!

gopherbot commented Nov 1, 2023

Uh oh!

gopherbot commented Nov 1, 2023

Uh oh!

gopherbot commented Nov 1, 2023

Uh oh!

gopherbot commented Nov 1, 2023

Uh oh!

gopherbot commented Nov 1, 2023

Uh oh!

gopherbot commented Nov 1, 2023

Uh oh!

gopherbot commented Nov 4, 2023

Uh oh!

gopherbot commented Nov 6, 2023

Uh oh!

gopherbot commented Nov 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants