internal/zstd: enforce block size limit according to RFC 8878#64155
Open
aimuz wants to merge 1 commit intogolang:masterfrom
Open
internal/zstd: enforce block size limit according to RFC 8878#64155aimuz wants to merge 1 commit intogolang:masterfrom
aimuz wants to merge 1 commit intogolang:masterfrom
Conversation
Contributor
Author
|
wait #64056 |
Contributor
|
This PR (HEAD: e602850) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/542417. Important tips:
|
This change updates the zstd reader implementation to check for block size limits as specified by the zstd specification RFC 3.1.1.2.4. Now, it ensures that both decompressed and compressed sizes of any block do not exceed the frame's Block_Maximum_Size. The previous logic only checked the buffer and literal buffer combined size against a hard-coded maximum which did not account for varying frame sizes or match lengths. This has been corrected to dynamically calculate the size based on actual literals and matches processed, ensuring compliance with the standard.
Contributor
|
This PR (HEAD: 727183e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/542417. Important tips:
|
Contributor
|
Message from Aimuz me: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/542417. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the zstd reader implementation to check for block
size limits as specified by the zstd specification RFC 3.1.1.2.4.
Now, it ensures that both decompressed and compressed sizes of any block
do not exceed the frame's Block_Maximum_Size.
The previous logic only checked the buffer and literal buffer combined
size against a hard-coded maximum which did not account for varying frame
sizes or match lengths. This has been corrected to dynamically calculate
the size based on actual literals and matches processed, ensuring
compliance with the standard.
Updates #63824