-
Notifications
You must be signed in to change notification settings - Fork 18.5k
hash/maphash: parallel run test #66359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR (HEAD: a11b314) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/572195. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from qiulaidongfeng: Patch Set 1: Run-TryBot+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from qiulaidongfeng: Patch Set 1: -Run-TryBot Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Gopher Robot: Patch Set 1: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
This PR (HEAD: e2efd34) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/572195. Important tips:
|
|
Message from qiulaidongfeng: Patch Set 3: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Gopher Robot: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Gopher Robot: Patch Set 3: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from qiulaidongfeng: Patch Set 3: -Run-TryBot Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from qiulaidongfeng: Patch Set 4: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-18T22:49:14Z","revision":"128482218d94512bfdc81508eb52d9b6ecae2417"} Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from qiulaidongfeng: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
This PR (HEAD: 5574b89) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/572195. Important tips:
|
|
Message from qiulaidongfeng: Patch Set 5: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-24T01:33:50Z","revision":"b685c5ef38290f18c92b84aafa7cd8c54b3a60d4"} Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from qiulaidongfeng: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Go LUCI: Patch Set 5: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Keith Randall: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from qiulaidongfeng: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Keith Randall: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
5574b89 to
0338321
Compare
|
This PR (HEAD: 0338321) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/572195. Important tips:
|
|
This PR (HEAD: 7f68483) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/572195. Important tips:
|
|
Message from qiulaidongfeng: Patch Set 7: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Go LUCI: Patch Set 7: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Go LUCI: Patch Set 7: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Keith Randall: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from qiulaidongfeng: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
This reduces the go test hash/maphash time by more than half. Change-Id: I4ea5f6af5263060f2f24d273f29a56d57df0d961
|
Message from qiulaidongfeng: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Keith Randall: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from qiulaidongfeng: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Keith Randall: Patch Set 7: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
7f68483 to
2827725
Compare
|
This PR (HEAD: 2827725) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/572195. Important tips:
|
|
Message from qiulaidongfeng: Patch Set 8: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Keith Randall: Patch Set 9: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Go LUCI: Patch Set 9: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-01T13:53:03Z","revision":"784bc7b9bca1814d9e152e84348ea94bca66c77f"} Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Keith Randall: Patch Set 9: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Keith Randall: Patch Set 9: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Go LUCI: Patch Set 9: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
|
Message from Go LUCI: Patch Set 9: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572195. |
This is a reapplication of CL 564576. This reduces the go test hash/maphash time by more than half. After investigation it was confirmed that the original CL would cause OOM when 32-bit machine. This CL add testenv.ParallelOn64Bit for tests that can be parallel on 64-bit machines, it is not parallel on 32-bit machines, because CL 564995 require the same API. Change-Id: I1b7feaa07716cb3f55db4671653348fabf2396b0 GitHub-Last-Rev: 2827725 GitHub-Pull-Request: #66359 Cq-Include-Trybots: luci.golang.try:gotip-linux-386-longtest Reviewed-on: https://go-review.googlesource.com/c/go/+/572195 Reviewed-by: Keith Randall <khr@google.com> Auto-Submit: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
|
This PR is being closed because golang.org/cl/572195 has been merged. |
This is a reapplication of CL 564576. This reduces the go test hash/maphash time by more than half. After investigation it was confirmed that the original CL would cause OOM when 32-bit machine. This CL add testenv.ParallelOn64Bit for tests that can be parallel on 64-bit machines, it is not parallel on 32-bit machines, because CL 564995 require the same API. Change-Id: I1b7feaa07716cb3f55db4671653348fabf2396b0 GitHub-Last-Rev: 28277255587f6a1b92b9bf1848e1f53adaca64dc GitHub-Pull-Request: golang/go#66359 Cq-Include-Trybots: luci.golang.try:gotip-linux-386-longtest Reviewed-on: https://go-review.googlesource.com/c/go/+/572195 Reviewed-by: Keith Randall <khr@google.com> Auto-Submit: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This is a reapplication of CL 564576. This reduces the go test hash/maphash time by more than half. After investigation it was confirmed that the original CL would cause OOM when 32-bit machine. This CL add testenv.ParallelOn64Bit for tests that can be parallel on 64-bit machines, it is not parallel on 32-bit machines, because CL 564995 require the same API. Change-Id: I1b7feaa07716cb3f55db4671653348fabf2396b0 GitHub-Last-Rev: 28277255587f6a1b92b9bf1848e1f53adaca64dc GitHub-Pull-Request: golang/go#66359 Cq-Include-Trybots: luci.golang.try:gotip-linux-386-longtest Reviewed-on: https://go-review.googlesource.com/c/go/+/572195 Reviewed-by: Keith Randall <khr@google.com> Auto-Submit: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This is a reapplication of CL 564576.
This reduces the go test hash/maphash time
by more than half.
After investigation it was confirmed that
the original CL would cause OOM when 32-bit machine.
This CL add testenv.ParallelOn64Bit for tests
that can be parallel on 64-bit machines,
it is not parallel on 32-bit machines,
because CL 564995 require the same API.
Cq-Include-Trybots: luci.golang.try:gotip-linux-386-longtest