net/http: initialize Value with File length in cloneMultipartForm #69943

1911860538 · 2024-10-20T05:11:20Z

Improve the initialization of the Value map in cloneMultipartForm by
utilizing the length of the File map to optimize memory allocation.

…length

gopherbot · 2024-10-20T05:15:30Z

This PR (HEAD: a9683ba) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/621235.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-20T05:22:05Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-20T05:22:05Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-21T17:05:55Z

Message from 黄志文:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-21T18:05:35Z

Message from Damien Neil:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-21T18:05:36Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-21T17:52:23Z","revision":"e2f1fbcddf52ed61401e1fdd3963eec8847fdbfd"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-21T18:05:37Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-21T17:52:23Z","revision":"e2f1fbcddf52ed61401e1fdd3963eec8847fdbfd"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-21T19:00:02Z

Message from Damien Neil:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-21T19:00:03Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-21T19:00:03Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-29T10:06:07Z

Message from Christian Ekrem:

Patch Set 3: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-29T11:37:27Z

Message from 黄志文:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-13T02:55:29Z

Message from 黄志文:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-08T09:56:51Z

Message from 黄志文:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-06T17:17:36Z

Message from qiu laidongfeng2:

Patch Set 3: Code-Review+1 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-06T17:17:37Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-04-06T17:07:04Z","revision":"e2f1fbcddf52ed61401e1fdd3963eec8847fdbfd"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-06T17:24:27Z

Message from qiu laidongfeng2:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-06T17:24:28Z

Message from Go LUCI:

Patch Set 3:

This CL has failed the run. Reason:

Failed Tryjobs:

golang/try/gotip-linux-arm64. Summary (view all results):

go on master (change 621235)

To reproduce, try gomote repro 8718319918851716977.

Additional links for debugging:

go tool dist test -json output [shard 1]

golang/try/gotip-linux-arm64-boringcrypto. Summary (view all results):

go on master (change 621235)

To reproduce, try gomote repro 8718319918851716961.

Additional links for debugging:

go tool dist test -json output [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-06T17:24:28Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-09T21:15:24Z

Message from Sean Liao:

Patch Set 4: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-09T21:23:06Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-04-09T21:09:10Z","revision":"ea686adb21c9bf9b2f67ebf3b8c644a1718180b6"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-09T21:37:56Z

Message from Sean Liao:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-09T21:37:57Z

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-09T21:37:57Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-09T21:52:21Z

Message from Sean Liao:

Patch Set 4: Auto-Submit+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-09T22:28:51Z

Message from Dmitri Shuralyov:

Patch Set 4: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-09T22:36:28Z

Message from Dmitri Shuralyov:

Patch Set 5: Auto-Submit+1 TryBot-Bypass+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621235.
After addressing review feedback, remember to publish your drafts!

Improve the initialization of the Value map in cloneMultipartForm by utilizing the length of the File map to optimize memory allocation. Change-Id: I97ba9e19b2718a75c270e6df21306f4c82656c71 GitHub-Last-Rev: a9683ba GitHub-Pull-Request: #69943 Reviewed-on: https://go-review.googlesource.com/c/go/+/621235 Reviewed-by: Christian Ekrem <christianekrem@gmail.com> Reviewed-by: Sean Liao <sean@liao.dev> Reviewed-by: qiu laidongfeng2 <2645477756@qq.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Damien Neil <dneil@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>

gopherbot · 2025-04-10T00:12:22Z

This PR is being closed because golang.org/cl/621235 has been merged.

net/http: enhance cloneMultipartForm by initializing Value with File …

a9683ba

…length

1911860538 changed the title ~~net/http: enhance cloneMultipartForm by initializing Value with File …~~ net/http: enhance cloneMultipartForm by initializing Value with File length Oct 20, 2024

1911860538 changed the title ~~net/http: enhance cloneMultipartForm by initializing Value with File length~~ net/http: initialize Value with File length in cloneMultipartForm Oct 20, 2024

This comment was marked as duplicate.

Sign in to view

gopherbot closed this Apr 10, 2025

net/http: initialize Value with File length in cloneMultipartForm #69943

net/http: initialize Value with File length in cloneMultipartForm #69943

Uh oh!

Conversation

1911860538 commented Oct 20, 2024 • edited by dmitshur Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Oct 20, 2024

Uh oh!

gopherbot commented Oct 20, 2024

Uh oh!

gopherbot commented Oct 20, 2024

Uh oh!

gopherbot commented Oct 21, 2024

Uh oh!

gopherbot commented Oct 21, 2024

Uh oh!

gopherbot commented Oct 21, 2024

Uh oh!

gopherbot commented Oct 21, 2024

Uh oh!

gopherbot commented Oct 21, 2024

Uh oh!

gopherbot commented Oct 21, 2024

Uh oh!

gopherbot commented Oct 21, 2024

Uh oh!

This comment was marked as duplicate.

Uh oh!

gopherbot commented Oct 29, 2024

Uh oh!

gopherbot commented Oct 29, 2024

Uh oh!

gopherbot commented Feb 13, 2025

Uh oh!

gopherbot commented Mar 8, 2025

Uh oh!

gopherbot commented Apr 6, 2025

Uh oh!

gopherbot commented Apr 6, 2025

Uh oh!

gopherbot commented Apr 6, 2025

Uh oh!

gopherbot commented Apr 6, 2025

Uh oh!

gopherbot commented Apr 6, 2025

Uh oh!

gopherbot commented Apr 9, 2025

Uh oh!

gopherbot commented Apr 9, 2025

Uh oh!

gopherbot commented Apr 9, 2025

Uh oh!

gopherbot commented Apr 9, 2025

Uh oh!

gopherbot commented Apr 9, 2025

Uh oh!

gopherbot commented Apr 9, 2025

Uh oh!

gopherbot commented Apr 9, 2025

Uh oh!

gopherbot commented Apr 9, 2025

Uh oh!

gopherbot commented Apr 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

1911860538 commented Oct 20, 2024 •

edited by dmitshur

Loading