reflect: add TypeAssert[T] #71639

mateusz834 · 2025-02-10T14:46:10Z

This implementation is zero-alloc when T is a concrete type,
allocates when val contains a method or when T is a interface
and Value was obtained for example through Elem(), in which case
it has to be allocated to avoid sharing the same memory.

goos: linux
goarch: amd64
pkg: reflect
cpu: AMD Ryzen 5 4600G with Radeon Graphics
│ /tmp/bench2 │
│ sec/op │
TypeAssert/TypeAssertint-12 2.725n ± 1%
TypeAssert/TypeAssertuint8-12 2.599n ± 1%
TypeAssert/TypeAssertfmt.Stringer-12 8.470n ± 0%
TypeAssert/TypeAssertfmt.Stringer-12 8.460n ± 1%
TypeAssert/TypeAssertinterface_{}-12 4.181n ± 1%
TypeAssert/TypeAssertinterface_{}-12 4.178n ± 1%
TypeAssert/TypeAsserttime.Time-12 2.839n ± 0%
TypeAssert/TypeAssertfunc()_string-12 151.1n ± 1%
geomean 6.645n

                                                                     │ /tmp/bench2  │
                                                                     │     B/op     │

TypeAssert/TypeAssertint-12 0.000 ± 0%
TypeAssert/TypeAssertuint8-12 0.000 ± 0%
TypeAssert/TypeAssertfmt.Stringer-12 0.000 ± 0%
TypeAssert/TypeAssertfmt.Stringer-12 0.000 ± 0%
TypeAssert/TypeAssertinterface_{}-12 0.000 ± 0%
TypeAssert/TypeAssertinterface_{}-12 0.000 ± 0%
TypeAssert/TypeAsserttime.Time-12 0.000 ± 0%
TypeAssert/TypeAssertfunc()_string-12 72.00 ± 0%
geomean ¹

Fixes #62121

gopherbot · 2025-02-10T15:07:19Z

This PR (HEAD: b35a231) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/648056.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-02-10T15:17:41Z

Message from Mateusz Poliwczak:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-10T15:29:03Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-02-10T15:07:38Z","revision":"22213209ba3888233ea8cf82cac5372c6ae695ba"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-10T15:29:03Z

Message from Mateusz Poliwczak:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-10T15:53:49Z

Message from Mateusz Poliwczak:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-10T15:53:49Z

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-10T15:53:50Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-11T11:33:32Z

This PR (HEAD: eb46a00) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/648056.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-02-11T11:42:23Z

Message from Mateusz Poliwczak:

Patch Set 2: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-11T11:50:59Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-02-11T11:34:47Z","revision":"8b4456e086f834a678828b5abf3f4f4fc7606e38"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-11T11:59:02Z

Message from Mateusz Poliwczak:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-11T11:59:03Z

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64-misccompile has failed with summary (view all results):

go on master (change 648056)

Error:

shard 4: failed to run compile goos:"freebsd" goarch:"386" port: exit status 1
failed to run compile goos:"freebsd" goarch:"amd64" port: exit status 1
failed to run compile goos:"freebsd" goarch:"arm" port: exit status 1
failed to run compile goos:"freebsd" goarch:"arm64" port: exit status 1

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-11T11:59:03Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-11T12:20:57Z

This PR (HEAD: e452d77) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/648056.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-02-11T13:54:04Z

Message from Mateusz Poliwczak:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-11T13:54:04Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-02-11T13:38:42Z","revision":"4e5f8f42e60d3744eb95f2e0feb24c6072a333e5"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-11T14:12:38Z

Message from Mateusz Poliwczak:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-11T14:12:38Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-11T14:12:39Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-11T17:04:48Z

This PR (HEAD: e79e2ea) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/648056.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-02-11T17:23:54Z

Message from Ian Lance Taylor:

Patch Set 4: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-11T17:23:54Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-02-11T17:15:10Z","revision":"679b59c33ef6a9ae28e4227314632fdef56d5e27"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-11T17:23:55Z

Message from Mateusz Poliwczak:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-11T17:49:30Z

Message from Ian Lance Taylor:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-11T17:49:30Z

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-11T17:49:31Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-07T18:35:40Z

This PR (HEAD: 83c22e1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/648056.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-05-20T07:40:58Z

Message from Mateusz Poliwczak:

Patch Set 9: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T07:40:58Z

Message from Go LUCI:

Patch Set 9:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-wasip1-wasm_wasmtime has failed with summary (view all results):

go on master (change 648056)

To reproduce, try gomote repro 8714370296749803953.

Additional links for debugging:

go tool dist test -json output [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T08:13:16Z

Message from Mateusz Poliwczak:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

Change-Id: Id8d5f247884fbe189a4c778203ea7cf575b1a93a

Change-Id: Id86c379adcfa38b26f16e1ceb8637821ab158e9a

Change-Id: Ib84e1f9f557c5a0605ebacdcf57b2f488a7ab186

Change-Id: Iae78e5cc2ca10468d2084e9caa8918792af9be83

gopherbot · 2025-05-20T15:09:37Z

This PR (HEAD: c2b7923) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/648056.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-05-20T15:17:00Z

Message from Mateusz Poliwczak:

Patch Set 10: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T15:24:01Z

Message from Go LUCI:

Patch Set 10:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-05-20T15:09:56Z","revision":"b5756cc76c689fe22ae54bf8dd46844015f19f2f"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T15:31:18Z

Message from Cherry Mui:

Patch Set 10: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

Change-Id: I2b035a17ce7479ea47d247deafbc8b4ee23ee442

gopherbot · 2025-05-20T15:39:26Z

This PR (HEAD: ce89a53) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/648056.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-05-20T15:53:13Z

Message from Go LUCI:

Patch Set 10: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T15:53:13Z

Message from Mateusz Poliwczak:

Patch Set 11: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T15:53:14Z

Message from Go LUCI:

Patch Set 11:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-05-20T15:42:25Z","revision":"a4c446d69f496eb31367985d21681f9fd0767af0"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T16:00:23Z

Message from Cherry Mui:

Patch Set 11: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T16:08:41Z

Message from Keith Randall:

Patch Set 11: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T16:36:54Z

Message from Mateusz Poliwczak:

Patch Set 11: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T16:36:54Z

Message from Go LUCI:

Patch Set 11:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T16:36:55Z

Message from Go LUCI:

Patch Set 11: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-05-20T18:39:26Z

Message from Mateusz Poliwczak:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/648056.
After addressing review feedback, remember to publish your drafts!

This implementation is zero-alloc when T is a concrete type, allocates when val contains a method or when T is a interface and Value was obtained for example through Elem(), in which case it has to be allocated to avoid sharing the same memory. goos: linux goarch: amd64 pkg: reflect cpu: AMD Ryzen 5 4600G with Radeon Graphics │ /tmp/bench2 │ │ sec/op │ TypeAssert/TypeAssert[int](int)-12 2.725n ± 1% TypeAssert/TypeAssert[uint8](int)-12 2.599n ± 1% TypeAssert/TypeAssert[fmt.Stringer](reflect_test.testTypeWithMethod)-12 8.470n ± 0% TypeAssert/TypeAssert[fmt.Stringer](*reflect_test.testTypeWithMethod)-12 8.460n ± 1% TypeAssert/TypeAssert[interface_{}](int)-12 4.181n ± 1% TypeAssert/TypeAssert[interface_{}](reflect_test.testTypeWithMethod)-12 4.178n ± 1% TypeAssert/TypeAssert[time.Time](time.Time)-12 2.839n ± 0% TypeAssert/TypeAssert[func()_string](func()_string)-12 151.1n ± 1% geomean 6.645n │ /tmp/bench2 │ │ B/op │ TypeAssert/TypeAssert[int](int)-12 0.000 ± 0% TypeAssert/TypeAssert[uint8](int)-12 0.000 ± 0% TypeAssert/TypeAssert[fmt.Stringer](reflect_test.testTypeWithMethod)-12 0.000 ± 0% TypeAssert/TypeAssert[fmt.Stringer](*reflect_test.testTypeWithMethod)-12 0.000 ± 0% TypeAssert/TypeAssert[interface_{}](int)-12 0.000 ± 0% TypeAssert/TypeAssert[interface_{}](reflect_test.testTypeWithMethod)-12 0.000 ± 0% TypeAssert/TypeAssert[time.Time](time.Time)-12 0.000 ± 0% TypeAssert/TypeAssert[func()_string](func()_string)-12 72.00 ± 0% geomean ¹ Fixes #62121 Change-Id: I0911c70c5966672c930d387438643f94a40441c4 GitHub-Last-Rev: ce89a53 GitHub-Pull-Request: #71639 Reviewed-on: https://go-review.googlesource.com/c/go/+/648056 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com>

gopherbot · 2025-05-20T19:47:24Z

This PR is being closed because golang.org/cl/648056 has been merged.

This implementation is zero-alloc when T is a concrete type, allocates when val contains a method or when T is a interface and Value was obtained for example through Elem(), in which case it has to be allocated to avoid sharing the same memory. goos: linux goarch: amd64 pkg: reflect cpu: AMD Ryzen 5 4600G with Radeon Graphics │ /tmp/bench2 │ │ sec/op │ TypeAssert/TypeAssert[int](int)-12 2.725n ± 1% TypeAssert/TypeAssert[uint8](int)-12 2.599n ± 1% TypeAssert/TypeAssert[fmt.Stringer](reflect_test.testTypeWithMethod)-12 8.470n ± 0% TypeAssert/TypeAssert[fmt.Stringer](*reflect_test.testTypeWithMethod)-12 8.460n ± 1% TypeAssert/TypeAssert[interface_{}](int)-12 4.181n ± 1% TypeAssert/TypeAssert[interface_{}](reflect_test.testTypeWithMethod)-12 4.178n ± 1% TypeAssert/TypeAssert[time.Time](time.Time)-12 2.839n ± 0% TypeAssert/TypeAssert[func()_string](func()_string)-12 151.1n ± 1% geomean 6.645n │ /tmp/bench2 │ │ B/op │ TypeAssert/TypeAssert[int](int)-12 0.000 ± 0% TypeAssert/TypeAssert[uint8](int)-12 0.000 ± 0% TypeAssert/TypeAssert[fmt.Stringer](reflect_test.testTypeWithMethod)-12 0.000 ± 0% TypeAssert/TypeAssert[fmt.Stringer](*reflect_test.testTypeWithMethod)-12 0.000 ± 0% TypeAssert/TypeAssert[interface_{}](int)-12 0.000 ± 0% TypeAssert/TypeAssert[interface_{}](reflect_test.testTypeWithMethod)-12 0.000 ± 0% TypeAssert/TypeAssert[time.Time](time.Time)-12 0.000 ± 0% TypeAssert/TypeAssert[func()_string](func()_string)-12 72.00 ± 0% geomean ¹ Fixes golang#62121 Change-Id: I0911c70c5966672c930d387438643f94a40441c4 GitHub-Last-Rev: ce89a53 GitHub-Pull-Request: golang#71639 Reviewed-on: https://go-review.googlesource.com/c/go/+/648056 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com>

mateusz834 force-pushed the reflect-typeassert branch from 10ff4ad to b35a231 Compare February 10, 2025 14:49

mateusz834 force-pushed the reflect-typeassert branch from e79e2ea to 83c22e1 Compare April 7, 2025 18:28

mateusz834 force-pushed the reflect-typeassert branch from 83c22e1 to cff1e5c Compare May 17, 2025 18:33

mateusz834 added 7 commits May 20, 2025 17:03

reflect: add TypeAssert[T]

25be293

Make sure that it is equivalent to v.Interface().(T)

bbd039f

fix typo

53a5a75

update

a69119e

Change-Id: Id8d5f247884fbe189a4c778203ea7cf575b1a93a

update

9abdce3

Change-Id: Id86c379adcfa38b26f16e1ceb8637821ab158e9a

fix TypeAssert with T and v iface, but different

80a9bb4

Change-Id: Ib84e1f9f557c5a0605ebacdcf57b2f488a7ab186

update, based on review comments

c2b7923

Change-Id: Iae78e5cc2ca10468d2084e9caa8918792af9be83

mateusz834 force-pushed the reflect-typeassert branch from 2ab425a to c2b7923 Compare May 20, 2025 15:03

update relnotes

ce89a53

Change-Id: I2b035a17ce7479ea47d247deafbc8b4ee23ee442

gopherbot closed this May 20, 2025

reflect: add TypeAssert[T] #71639

reflect: add TypeAssert[T] #71639

Uh oh!

Conversation

mateusz834 commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Feb 10, 2025

Uh oh!

gopherbot commented Feb 10, 2025

Uh oh!

gopherbot commented Feb 10, 2025

Uh oh!

gopherbot commented Feb 10, 2025

Uh oh!

gopherbot commented Feb 10, 2025

Uh oh!

gopherbot commented Feb 10, 2025

Uh oh!

gopherbot commented Feb 10, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Feb 11, 2025

Uh oh!

gopherbot commented Apr 7, 2025

Uh oh!

gopherbot commented May 20, 2025

Uh oh!

gopherbot commented May 20, 2025

Uh oh!

gopherbot commented May 20, 2025

Uh oh!

gopherbot commented May 20, 2025

Uh oh!

gopherbot commented May 20, 2025

Uh oh!

gopherbot commented May 20, 2025

Uh oh!

gopherbot commented May 20, 2025

Uh oh!

gopherbot commented May 20, 2025

Uh oh!

gopherbot commented May 20, 2025

Uh oh!

gopherbot commented May 20, 2025

mateusz834 commented Feb 10, 2025 •

edited

Loading