-
Notifications
You must be signed in to change notification settings - Fork 18.6k
cmd/compile: devirtualize interface calls with type assertions #71711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: devirtualize interface calls with type assertions #71711
Conversation
|
This PR (HEAD: d3d5a3b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/649195. Important tips:
|
|
Message from Mateusz Poliwczak: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-13T10:48:08Z","revision":"e20cc0cbbdf6a2e296fdc0ba74f29990cb6f921e"} Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Mateusz Poliwczak: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Go LUCI: Patch Set 1: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64-boringcrypto has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
This PR (HEAD: 68ee1cb) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/649195. Important tips:
|
|
Message from Mateusz Poliwczak: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-13T14:06:46Z","revision":"e96478c514bba6c01cb6a7e0d840a6d21ee31409"} Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
This PR (HEAD: 0ec4e57) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/649195. Important tips:
|
|
Message from Mateusz Poliwczak: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Mateusz Poliwczak: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-13T14:35:38Z","revision":"22cc0462fbd827dd00ca621c87655ff5fed89f40"} Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Mateusz Poliwczak: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Go LUCI: Patch Set 3: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64-misccompile has failed with summary (view all results):
Error: Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Keith Randall: Patch Set 3: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
ff0149f to
96ba2f9
Compare
|
This PR (HEAD: 96ba2f9) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/649195. Important tips:
|
|
Message from Mateusz Poliwczak: Patch Set 4: Commit-Queue+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-14T14:18:16Z","revision":"f3ee009bd6eb8bdd32efb4e5684e7da307b9222c"} Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Mateusz Poliwczak: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
Change-Id: I33ebc2734b404d61393f606950829b843b04111a
1aa3bbd to
942f16a
Compare
|
This PR (HEAD: 942f16a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/649195. Important tips:
|
Change-Id: I9ccc3dfbc0311edb7ce16f28de6ed8e8197ac76a
|
This PR (HEAD: 669e8aa) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/649195. Important tips:
|
Change-Id: Ic0453367df8032afedd048916c9292eafd75c2f3
669e8aa to
291add4
Compare
|
This PR (HEAD: 291add4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/649195. Important tips:
|
|
Message from Mateusz Poliwczak: Patch Set 7: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Go LUCI: Patch Set 7: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-14T18:47:10Z","revision":"e2a89f362804c0d25ad244f6e6559a86fa4d060f"} Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Mateusz Poliwczak: Patch Set 7: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Go LUCI: Patch Set 7: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Go LUCI: Patch Set 7: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Keith Randall: Patch Set 7: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
Change-Id: Iadcbf84a666a3e43ce2b460e064b111efa0f2022
b67d49e to
f63e6fa
Compare
|
This PR (HEAD: f63e6fa) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/649195. Important tips:
|
|
Message from Mateusz Poliwczak: Patch Set 8: Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Go LUCI: Patch Set 8: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-15T08:04:51Z","revision":"fcbbd3e4884491b4b85c11b4557e31bc265a051f"} Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Mateusz Poliwczak: Patch Set 8: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Go LUCI: Patch Set 8: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Go LUCI: Patch Set 8: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Keith Randall: Patch Set 8: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Mateusz Poliwczak: Patch Set 8: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Keith Randall: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
Message from Mateusz Poliwczak: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/649195. |
|
This PR is being closed because golang.org/cl/649195 has been abandoned. Going with CL 652036 |
This change adds support for #64824, which should
help with the new API added in #69521.
Fixes #64824
Updates #69521