-
Notifications
You must be signed in to change notification settings - Fork 18.7k
net: simplify readProtocols via sync.OnceFunc #73434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR (HEAD: a281dae) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/666635. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/666635. |
|
Message from 黄志文: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/666635. |
|
Message from Jorropo: Patch Set 2: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/666635. |
|
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-04-18T14:27:53Z","revision":"2206c003fdbab24a723608ff7f79ce9c81ec84b0"} Please don’t reply on this GitHub thread. Visit golang.org/cl/666635. |
|
Message from Jorropo: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/666635. |
|
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/666635. |
|
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/666635. |
|
Message from 黄志文: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/666635. |
|
Message from Jorropo: Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/666635. |
|
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-04-18T16:35:40Z","revision":"2206c003fdbab24a723608ff7f79ce9c81ec84b0"} Please don’t reply on this GitHub thread. Visit golang.org/cl/666635. |
|
Message from Jorropo: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/666635. |
|
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/666635. |
|
Message from Damien Neil: Patch Set 2: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/666635. |
In this case, using sync.OnceFunc is a better choice. Change-Id: I52d27b9741265c90300a04a03537020e1aaaaaa7 GitHub-Last-Rev: a281dae GitHub-Pull-Request: #73434 Reviewed-on: https://go-review.googlesource.com/c/go/+/666635 Reviewed-by: David Chase <drchase@google.com> Auto-Submit: Jorropo <jorropo.pgm@gmail.com> Reviewed-by: Damien Neil <dneil@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jorropo <jorropo.pgm@gmail.com>
|
This PR is being closed because golang.org/cl/666635 has been merged. |
In this case, using sync.OnceFunc is a better choice.