Skip to content

Conversation

@afiune
Copy link

@afiune afiune commented Apr 22, 2025

By default, range will cover the case where src is nil, but if dst is nil, then Copy will throw a panic like:

panic: assignment to entry in nil map

@google-cla
Copy link

google-cla bot commented Apr 22, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

By default, `range` will cover the case where `src` is `nil`, but if
`dst` is `nil`, then `Copy` will throw a panic like:
```
panic: assignment to entry in nil map
```

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
@afiune afiune force-pushed the afiune/maps/copy-nil branch from ef75c0f to f19b84e Compare April 22, 2025 22:04
@gopherbot
Copy link
Contributor

This PR (HEAD: f19b84e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/667395.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@Jorropo
Copy link
Member

Jorropo commented Apr 24, 2025

This has been closed on gerrit, but for some reason the bot hasn't updated the status here.

@Jorropo Jorropo closed this Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants