internal/profile: optimize Parse allocs #76145

pymq · 2025-11-02T11:05:35Z

In our case, it greatly improves the performance of continuously collecting diff profiles from the net/http/pprof endpoint, such as /debug/pprof/allocs?seconds=30.

This CL is a cherry-pick of my PR upstream: google/pprof#951

Benchmark of profile Parse func:

goos: linux
goarch: amd64
pkg: github.com/google/pprof/profile
cpu: 13th Gen Intel(R) Core(TM) i7-1360P
│ old-parse.txt │ new-parse.txt │
│ sec/op │ sec/op vs base │
Parse-16 62.07m ± 13% 55.54m ± 13% -10.52% (p=0.035 n=10)

     │ old-parse.txt │            new-parse.txt             │
     │     B/op      │     B/op      vs base                │

Parse-16 47.56Mi ± 0% 41.09Mi ± 0% -13.59% (p=0.000 n=10)

     │ old-parse.txt │            new-parse.txt            │
     │   allocs/op   │  allocs/op   vs base                │

Parse-16 272.9k ± 0% 175.8k ± 0% -35.58% (p=0.000 n=10)

gopherbot · 2025-11-02T11:13:33Z

This PR (HEAD: a09108f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/717081.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-11-02T11:21:03Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/717081.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-02T11:21:03Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/717081.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-02T11:43:42Z

Message from Maksim Merzhanov:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/717081.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-02T11:58:39Z

Message from t hepudds:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/717081.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-02T12:06:14Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-11-02T11:51:48Z","revision":"137b22e6ae8f7af5b751069fb5b7ea1afd9bde56"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/717081.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-02T12:21:33Z

Message from t hepudds:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/717081.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-02T12:21:34Z

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-386 has failed with summary (view all results):

go on master (change 717081)

To reproduce, try gomote repro 8699314394012479297.

Additional links for debugging:

go tool dist test -json output [shard 4]

Please don’t reply on this GitHub thread. Visit golang.org/cl/717081.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-02T12:21:34Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/717081.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-02T12:29:05Z

Message from t hepudds:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/717081.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-02T12:29:06Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-11-02T12:15:52Z","revision":"137b22e6ae8f7af5b751069fb5b7ea1afd9bde56"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/717081.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-02T12:36:37Z

Message from t hepudds:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/717081.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-02T12:36:38Z

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/717081.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-02T12:36:38Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/717081.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-02T17:26:47Z

Message from Florian Lehner:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/717081.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-03T16:33:48Z

Message from Michael Pratt:

Patch Set 2: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/717081.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-03T17:09:56Z

Message from t hepudds:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/717081.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-03T17:54:56Z

Message from Michael Knyszek:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/717081.
After addressing review feedback, remember to publish your drafts!

In our case, it greatly improves the performance of continuously collecting diff profiles from the net/http/pprof endpoint, such as /debug/pprof/allocs?seconds=30. This CL is a cherry-pick of my PR upstream: google/pprof#951 Benchmark of profile Parse func: goos: linux goarch: amd64 pkg: github.com/google/pprof/profile cpu: 13th Gen Intel(R) Core(TM) i7-1360P │ old-parse.txt │ new-parse.txt │ │ sec/op │ sec/op vs base │ Parse-16 62.07m ± 13% 55.54m ± 13% -10.52% (p=0.035 n=10) │ old-parse.txt │ new-parse.txt │ │ B/op │ B/op vs base │ Parse-16 47.56Mi ± 0% 41.09Mi ± 0% -13.59% (p=0.000 n=10) │ old-parse.txt │ new-parse.txt │ │ allocs/op │ allocs/op vs base │ Parse-16 272.9k ± 0% 175.8k ± 0% -35.58% (p=0.000 n=10) Change-Id: I737ff9b9f815fdc56bc3b5743403717c4b6f07fd GitHub-Last-Rev: a09108f GitHub-Pull-Request: #76145 Reviewed-on: https://go-review.googlesource.com/c/go/+/717081 Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Florian Lehner <lehner.florian86@gmail.com>

gopherbot · 2025-11-03T18:03:21Z

This PR is being closed because golang.org/cl/717081 has been merged.

internal/profile: optimize Parse performance

a09108f

austinderek mentioned this pull request Nov 2, 2025

internal/profile: optimize Parse allocs PullRequestInc/go#133

Closed

gopherbot closed this Nov 3, 2025

internal/profile: optimize Parse allocs #76145

internal/profile: optimize Parse allocs #76145

Conversation

pymq commented Nov 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Nov 2, 2025

Uh oh!

gopherbot commented Nov 2, 2025

Uh oh!

gopherbot commented Nov 2, 2025

Uh oh!

gopherbot commented Nov 2, 2025

Uh oh!

gopherbot commented Nov 2, 2025

Uh oh!

gopherbot commented Nov 2, 2025

Uh oh!

gopherbot commented Nov 2, 2025

Uh oh!

gopherbot commented Nov 2, 2025

Uh oh!

gopherbot commented Nov 2, 2025

Uh oh!

gopherbot commented Nov 2, 2025

Uh oh!

gopherbot commented Nov 2, 2025

Uh oh!

gopherbot commented Nov 2, 2025

Uh oh!

gopherbot commented Nov 2, 2025

Uh oh!

gopherbot commented Nov 2, 2025

Uh oh!

gopherbot commented Nov 2, 2025

Uh oh!

gopherbot commented Nov 3, 2025

Uh oh!

gopherbot commented Nov 3, 2025

Uh oh!

gopherbot commented Nov 3, 2025

Uh oh!

gopherbot commented Nov 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pymq commented Nov 2, 2025 •

edited

Loading