Skip to content

Conversation

@shdunning
Copy link
Contributor

@shdunning shdunning commented Jul 5, 2019

Recently, Atlassian decided to remove userKey from JWT construction b/c they determined that it could contain personally identifiable information. They've since switched to the user account ID. This change updates the jira JWT to reflect these recent change.

Fixes #312

@gopherbot
Copy link
Contributor

This PR (HEAD: 344bb60) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/185081 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@shdunning
Copy link
Contributor Author

any update here? we have this hacked out in our vendor libs currently as it's needed to fix a production integration.

@chetanyakan
Copy link

Fixes #312

@bradfitz bradfitz changed the title Update jira jwt subject per Atlassian's recent GDPR changes jira: update jira JWT subject per Atlassian's recent GDPR changes Nov 22, 2019
@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 3: Run-TryBot+1 Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/185081.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=2c54c384


Please don’t reply on this GitHub thread. Visit golang.org/cl/185081.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 22, 2019
Recently, Atlassian decided to remove `userKey` from JWT construction b/c they determined that it could contain personally identifiable information. They've since switched to the user account ID. This change updates the jira JWT to reflect these recent change.

Fixes #312

Change-Id: I4bd66cf925fdf38e02dd665befb5ab5f19f14ee7
GitHub-Last-Rev: 344bb60
GitHub-Pull-Request: #389
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/185081
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/185081 has been merged.

@gopherbot gopherbot closed this Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Jira definition to account for deprecated sub claim

4 participants