Skip to content

jira: update jira JWT subject per Atlassian's recent GDPR changes #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

jira: update jira JWT subject per Atlassian's recent GDPR changes #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jira/jira.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ func (js jwtSource) Token() (*oauth2.Token, error) {
exp := time.Duration(59) * time.Second
claimSet := &ClaimSet{
Issuer: fmt.Sprintf("urn:atlassian:connect:clientid:%s", js.conf.ClientID),
Subject: fmt.Sprintf("urn:atlassian:connect:userkey:%s", js.conf.Subject),
Subject: fmt.Sprintf("urn:atlassian:connect:useraccountid:%s", js.conf.Subject),
InstalledURL: js.conf.BaseURL,
AuthURL: js.conf.Endpoint.AuthURL,
IssuedAt: time.Now().Unix(),
Expand Down
8 changes: 4 additions & 4 deletions jira/jira_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func TestJWTFetch_JSONResponse(t *testing.T) {

conf := &Config{
BaseURL: "https://my.app.com",
Subject: "userkey",
Subject: "useraccountId",
Config: oauth2.Config{
ClientID: "super_secret_client_id",
ClientSecret: "super_shared_secret",
Expand Down Expand Up @@ -69,7 +69,7 @@ func TestJWTFetch_BadResponse(t *testing.T) {

conf := &Config{
BaseURL: "https://my.app.com",
Subject: "userkey",
Subject: "useraccountId",
Config: oauth2.Config{
ClientID: "super_secret_client_id",
ClientSecret: "super_shared_secret",
Expand Down Expand Up @@ -108,7 +108,7 @@ func TestJWTFetch_BadResponseType(t *testing.T) {

conf := &Config{
BaseURL: "https://my.app.com",
Subject: "userkey",
Subject: "useraccountId",
Config: oauth2.Config{
ClientID: "super_secret_client_id",
ClientSecret: "super_shared_secret",
Expand Down Expand Up @@ -145,7 +145,7 @@ func TestJWTFetch_Assertion(t *testing.T) {

conf := &Config{
BaseURL: "https://my.app.com",
Subject: "userkey",
Subject: "useraccountId",
Config: oauth2.Config{
ClientID: "super_secret_client_id",
ClientSecret: "super_shared_secret",
Expand Down