Skip to content

google: Add support for CredentialsParams, Client ID json, and JWT Subject #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

google: Add support for CredentialsParams, Client ID json, and JWT Subject #490

wants to merge 17 commits into from

Conversation

@andyrzhao
Copy link
Contributor

@andyrzhao andyrzhao commented Apr 19, 2021 •
edited
Loading

*Add support for Google Developers Console client_credentials.json as a TokenSource.
*Add support for JWT Subject (for domain-wide delegation when using service account as credentials source.)
*Add support for non-default AuthURL and TokenURL for authorized user credentials source.

To support this change, two new exported functions FindDefaultCredentialsWithParams and CredentialsFromJSONWithParams are introduced.

andyrzhao added 15 commits May 5, 2020 16:55
@andyrzhao
google: Add support for 3-legged-OAuth using OAuth Client ID
ceaa866 
Add OAuthClientTokenSource in google/google.go
Add DefaultAuthorizationHandler in authhandler.go
@andyrzhao
google: Make state configurable in DefaultAuthorizationHandler
04f020b
@andyrzhao
authhandler: Add support for 3-legged-OAuth
1105999 
Added authhandler.go, which implements a TokenSource
to support "three-legged OAuth 2.0" via a custom
AuthorizationHandler.

Added default_authhandler.go to provide a command line
implementation for AuthorizationHandler.
@andyrzhao
authhandler: Add authhandler_test.go
cde11fb
@andyrzhao
authhandler: Update default_authhandler.go to inline handler logic
7c28922
@andyrzhao
authhandler: Rename to CmdAuthorizationHandler and add example_test.go
8a926e1
@andyrzhao
authhandler: Make authHandler the last parameter
ab12fee
@andyrzhao
authhandler: Remove CmdAuthorizationHandler and use it as example ins…
fcaf078 
…tead
@andyrzhao
authhandler: Reword comment regarding state
1ae3746
@andyrzhao
authhandler: Reword comment regarding state in example
48fc036
@andyrzhao
authhandler: Remove example_test.go
ca291c5
@andyrzhao
Merge pull request #1 from golang/master
89bf8af 
Sync from upstream
@andyrzhao
authhandler: Remove example_test.go
baf4632
@andyrzhao
google: Add support for TokenSourceParams, Client ID json, and JWT Su…
9b7db16 
…bject
@andyrzhao
Merge pull request #2 from golang/master
debdcb4 
Sync with upstream master
@google-cla google-cla bot added the cla: yes label Apr 19, 2021
@gopherbot
Copy link
Contributor

gopherbot commented Apr 19, 2021

This PR (HEAD: debdcb4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/311589 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Apr 20, 2021

Message from Shin Fan:

Patch Set 1: Code-Review+1 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/311589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Apr 20, 2021

Message from Cody Oss:

Patch Set 1:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/311589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Apr 21, 2021

This PR (HEAD: 3a734b4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/311589 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Apr 21, 2021

Message from Andy Zhao:

Patch Set 2:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/311589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Apr 21, 2021

Message from Cody Oss:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/311589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Apr 21, 2021

Message from Andy Zhao:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/311589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Apr 23, 2021

This PR (HEAD: eb92ab4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/311589 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Apr 23, 2021

Message from Andy Zhao:

Patch Set 3:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/311589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Apr 26, 2021

Message from Cody Oss:

Patch Set 3: Run-TryBot+1 Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/311589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Apr 26, 2021

Message from Go Bot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/311589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Apr 26, 2021

Message from Go Bot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/311589.
After addressing review feedback, remember to publish your drafts!

@andyrzhao andyrzhao changed the title google: Add support for TokenSourceParams, Client ID json, and JWT Subject google: Add support for CredentialsParams, Client ID json, and JWT Subject Apr 27, 2021
gopherbot pushed a commit that referenced this pull request Apr 27, 2021
@andyrzhao @shinfan
google: Add support for CredentialsParams, Client ID json, and JWT Su…
81ed05c 
…bject

*Add support for Google Developers Console client_credentials.json as a TokenSource.
*Add support for JWT Subject (for domain-wide delegation when using service account as credentials source.)
*Add support for non-default AuthURL and TokenURL for authorized user credentials source.

To support this change, two new exported functions FindDefaultCredentialsWithParams and CredentialsFromJSONWithParams are introduced.

Change-Id: Ib467822e2c14e02f8ae68586665c439960cfbd5c
GitHub-Last-Rev: eb92ab4
GitHub-Pull-Request: #490
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/311589
Reviewed-by: Shin Fan <shinfan@google.com>
Reviewed-by: Cody Oss <codyoss@google.com>
Trust: Shin Fan <shinfan@google.com>
Trust: Cody Oss <codyoss@google.com>
@gopherbot
Copy link
Contributor

gopherbot commented Apr 27, 2021

This PR is being closed because golang.org/cl/311589 has been merged.

@gopherbot gopherbot closed this Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andyrzhao @gopherbot