Skip to content

content/static,internal/dl: add links for Creative Commons license#2

Closed
rhnvrm wants to merge 1 commit into
golang:masterfrom
rhnvrm:master
Closed

content/static,internal/dl: add links for Creative Commons license#2
rhnvrm wants to merge 1 commit into
golang:masterfrom
rhnvrm:master

Conversation

@rhnvrm
Copy link
Copy Markdown
Contributor

@rhnvrm rhnvrm commented Feb 26, 2019

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Feb 26, 2019
@gopherbot
Copy link
Copy Markdown
Contributor

This PR (HEAD: cbe0f97) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/163746 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/163746.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Brad Fitzpatrick:

Patch Set 2:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/163746.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

This PR (HEAD: 2428b9d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/163746 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Agniva De Sarker:

Patch Set 5:

(1 comment)

Please also re-generate static.go by running "go generate ./content/static/". See README.md under content directory.


Please don’t reply on this GitHub thread. Visit golang.org/cl/163746.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

This PR (HEAD: 2628f6b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/163746 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Agniva De Sarker:

Patch Set 6:

(1 comment)

Apologies for the to and fro. Just one more thing.


Please don’t reply on this GitHub thread. Visit golang.org/cl/163746.
After addressing review feedback, remember to publish your drafts!

@rhnvrm rhnvrm changed the title Add missing links for creative commons license content/static,internal/dl: add links for Creative Commons license Feb 27, 2019
@gopherbot
Copy link
Copy Markdown
Contributor

Message from Agniva De Sarker:

Patch Set 7: Run-TryBot+1 Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/163746.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Gobot Gobot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=5ee77e73


Please don’t reply on this GitHub thread. Visit golang.org/cl/163746.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Gobot Gobot:

Patch Set 7: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/163746.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Feb 27, 2019
Fixes golang/go#30371

Change-Id: I7a503061d2f5adcf866a7f90eb26d425f732c44a
GitHub-Last-Rev: 2628f6b
GitHub-Pull-Request: #2
Reviewed-on: https://go-review.googlesource.com/c/163746
Reviewed-by: Agniva De Sarker <agniva.quicksilver@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Agniva De Sarker <agniva.quicksilver@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link
Copy Markdown
Contributor

This PR is being closed because golang.org/cl/163746 has been merged.

@gopherbot gopherbot closed this Feb 27, 2019
allenporter added a commit to allenporter/golang-website that referenced this pull request Apr 23, 2021
Fix the highlight in step golang#2 to reflect the actual lines of code
changed between the previous tutorial to include the updated
function call with a slice.
MK825 added a commit to MK825/website that referenced this pull request Oct 18, 2022
Fixes golang/go#30371

Change-Id: I7a503061d2f5adcf866a7f90eb26d425f732c44a
GitHub-Last-Rev: 2628f6b78e0fc6021d7b15a28f70de9fe67b4717
GitHub-Pull-Request: golang/website#2
Reviewed-on: https://go-review.googlesource.com/c/163746
Reviewed-by: Agniva De Sarker <agniva.quicksilver@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Agniva De Sarker <agniva.quicksilver@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants