Skip to content

solutions: update urfave/cli link to v3 GitHub URL#359

Open
Jah-yee wants to merge 1 commit into
golang:masterfrom
Jah-yee:fix/urfave-cli-v3-url
Open

solutions: update urfave/cli link to v3 GitHub URL#359
Jah-yee wants to merge 1 commit into
golang:masterfrom
Jah-yee:fix/urfave-cli-v3-url

Conversation

@Jah-yee
Copy link
Copy Markdown

@Jah-yee Jah-yee commented Apr 25, 2026

The pkg.go.dev URL redirects to v1.22.17 but the latest stable
version is v3.6.2. Update to the canonical GitHub URL which
automatically shows the latest version on pkg.go.dev.

Fixes #344

Fixes golang#344

The pkg.go.dev URL redirects to v1.22.17 but the latest stable
version is v3.6.2. Update to the canonical GitHub URL which
automatically shows the latest version on pkg.go.dev.
@gopherbot
Copy link
Copy Markdown
Contributor

This PR (HEAD: 460bf26) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/website/+/770646.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/770646.
After addressing review feedback, remember to publish your drafts!

@Jah-yee
Copy link
Copy Markdown
Author

Jah-yee commented Apr 30, 2026

Friendly ping #2 — just checking in. This is a simple one-line URL fix. Happy to adjust if needed 🙏

@Jah-yee
Copy link
Copy Markdown
Author

Jah-yee commented Apr 30, 2026

👋 Hi @dominikh @andybalholm — this PR is clean (mergeable, CI passing) and has been open for a week. Just wanted to check in! Is there anything I can improve to help move this forward? 🙏

@Jah-yee
Copy link
Copy Markdown
Author

Jah-yee commented May 2, 2026

Hi maintainers! This PR fixes issue #344 — it updates the urfave/cli URL from the old pkg.go.dev redirect (v1.22.17) to the canonical v3 GitHub URL (2-line doc fix). Requesting review from anyone available. Happy to make any changes, thanks!

@Jah-yee
Copy link
Copy Markdown
Author

Jah-yee commented May 2, 2026

Hi! I noticed the branch was updated on May 2. Just checking in — is there anything I can help with to move this review forward? Happy to make adjustments if needed.

@Jah-yee
Copy link
Copy Markdown
Author

Jah-yee commented Jun 5, 2026

👋 Hi maintainers, checking in on this PR. Happy to address any feedback or make changes.

@Jah-yee
Copy link
Copy Markdown
Author

Jah-yee commented Jun 6, 2026

Hi @golang/website, checking in — this urfave/cli v3 URL fix has been open 40+ days without review. Happy to make any adjustments. Thanks for considering it!

@dominikh
Copy link
Copy Markdown
Member

dominikh commented Jun 6, 2026

/cc @dmitshur

@dmitshur
Copy link
Copy Markdown
Member

dmitshur commented Jun 6, 2026

@Jah-yee Thanks for sending this change. Please see information posted in #359 (comment). I left review comments at https://go.dev/cl/770646.

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Dmitri Shuralyov:

Patch Set 1:

(6 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/770646.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants