Add ctxprop linter

[Gilthoniel]

Repository URL

https://github.com/Gilthoniel/ctxprop

Analyzer Requirements

• The analyzer must be more than one month old.
• The usage of AI must be explicitly expressed inside the readme.
• It must use go/analysis.
• It must not be a duplicate or too close to an existing analyzer.
• It must have a Go version inside the go.mod <= 1.25.0.
• The dependencies must be minimal.
• It must be available as a plugin.

Analyzer Goal

Finds bugs

Analyzer Description

We use internally a context interface that extends the standard Golang context one. As such we need to make sure that we propagate this context properly. It also detects when a struct passed to a function implements interface { Context() context.Context } to enforce the use of this context.

The contextcheck linter was not enough because very limited in what it actually checks and the maintainer does not want to support this pattern. The goal of this linter is to support a wider range of usages.

Analyzer License

MIT

Analyzer License Checks

• The file must start with LICENSE (capitalized).
• The file(s) must contain the required information by the license, e.g.: author, year, etc.

Analyzer Details

• It must have tests.
• It must not contain init().
• It must not contain panic().
• It must not contain log.Fatal().
• It must not contain os.Exit().
• It must not modify the AST.
• The configuration must not rely on external files.

Repository Details

• It must have a semver tag, e.g.: v1.0.0, v0.1.0 (0.0.x are not valid).
• I understand that tags must never be deleted or recreated once published.
• It must have a readme.
• The repository must have a CI.
• The CI must run on PR.
• The CI must run on the default branch.

Repository Recommendations

• It should have linting.
• It should have a .gitignore (IDE files, binaries, OS files, etc. should not be committed).
• Use main as the default branch name.

Pull Request

• Yes, I will wait for the approval of a maintainer before creating a PR.

[ldez]

The contextcheck linter was not enough because very limited in what it actually checks and the maintainer does not want to support this pattern. The goal of this linter is to support a wider range of usages.

I checked the contextcheck repo but I don't see any discussion on this topic (issues or PRs).

For now, IMHO this is a duplicate (with extension) of contextcheck

[Gilthoniel]

this is the discussion: kkHAIKE/contextcheck#20

[ldez]

From the discussion, the author of contextcheck didn't exactly reject the idea: he didn't answer to the question about adding an option about that.

I don't know what is the best approach here, but we need a clear statement from the author of contextcheck

For now, this analyzer covers the same things as contextcheck, so this is obviously a duplicate.