modernize: disable stringscut analyzer #6233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
bug
ldez
force-pushed
the
fix/modernize-stringscut
branch
from
eec9b40 to
13c9ce7
Compare
alexandear
approved these changes
Dec 4, 2025
scop
reviewed
Dec 4, 2025
Member
|
Has this been reported to the Go team already? Might be worth to let them know and fix the analyzer. If not already reported, I'll do that tomorrow. Thanks for the quick fix! 😃 |
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stringscutanalyzer reports false positives.And this is a more important problem because it applies suggested fixes that could creates bugs.
Related to #6232 (comment)