Skip to content

modernize: disable stringscut analyzer #6233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2025
+18 −2
Merged

modernize: disable stringscut analyzer #6233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions pkg/golinters/modernize/modernize.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ func New(settings *config.ModernizeSettings) *goanalysis.Linter {
var analyzers []*analysis.Analyzer

if settings == nil {
analyzers = modernize.Suite
analyzers = cleanSuite()
} else {
for _, analyzer := range modernize.Suite {
for _, analyzer := range cleanSuite() {
if slices.Contains(settings.Disable, analyzer.Name) {
continue
}
Expand All @@ -32,3 +32,19 @@ func New(settings *config.ModernizeSettings) *goanalysis.Linter {
nil).
WithLoadMode(goanalysis.LoadModeTypesInfo)
}

func cleanSuite() []*analysis.Analyzer {
var analyzers []*analysis.Analyzer

for _, analyzer := range modernize.Suite {
// Disabled because of false positives
// https://github.com/golang/go/issues/76687
if analyzer.Name == "stringscut" {
continue
}

analyzers = append(analyzers, analyzer)
}

return analyzers
}
Loading